Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌊 Stream overview page #204079

Merged
merged 13 commits into from
Jan 8, 2025

Conversation

flash1293
Copy link
Contributor

@flash1293 flash1293 commented Dec 12, 2024

Stacked on #204004

Screenshot 2024-12-12 at 17 19 58

Adds some bits to the stream overview page:

  • Number of docs for the current time range (let's stop here and don't build more of Kibana)
  • List of child streams for wired streams
  • Quick links tab (currently empty)

@flash1293 flash1293 added v9.0.0 backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.18.0 Feature:Streams This is the label for the Streams Project labels Dec 12, 2024
@simianhacker simianhacker marked this pull request as ready for review January 6, 2025 15:44
@simianhacker simianhacker requested a review from a team as a code owner January 6, 2025 15:44
Copy link
Member

@simianhacker simianhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good... I'd probably put "Tooltips" on the little icon controls but we can do that in a follow up.

@flash1293 flash1293 added the release_note:skip Skip the PR/issue when compiling release notes label Jan 8, 2025
@flash1293
Copy link
Contributor Author

Thanks @simianhacker , added the tooltips. I also fixed a managed: true that snuck in in what looks like a merge conflict: https://github.com/elastic/kibana/pull/204079/files#diff-18005311ea05fa61fa5ec13ed7e658bbebc45afd7cdb39d68924379668a3c151L225

Should be good now.

@flash1293
Copy link
Contributor Author

I'll merge on green UI

@flash1293 flash1293 enabled auto-merge (squash) January 8, 2025 14:30
@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 8, 2025

💔 Build Failed

Failed CI Steps

History

@flash1293 flash1293 merged commit 58d1522 into elastic:main Jan 8, 2025
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12675940351

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- [Streams] Dashboard linking (#204309)

Manual backport

To create the backport manually run:

node scripts/backport --pr 204079

Questions ?

Please refer to the Backport tool documentation

@flash1293 flash1293 added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Jan 10, 2025
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12713346506

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 10, 2025
Stacked on elastic#204004

<img width="1275" alt="Screenshot 2024-12-12 at 17 19 58"
src="https://github.com/user-attachments/assets/2ad14305-15c0-4522-8e70-5691c50e381b"
/>

Adds some bits to the stream overview page:
* Number of docs for the current time range (let's stop here and don't
build more of Kibana)
* List of child streams for wired streams
* Quick links tab (currently empty)

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 58d1522)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 10, 2025
# Backport

This will backport the following commits from `main` to `8.x`:
- [🌊 Stream overview page
(#204079)](#204079)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Joe
Reuter","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-08T17:34:22Z","message":"🌊
Stream overview page (#204079)\n\nStacked on
https://github.com/elastic/kibana/pull/204004\r\n\r\n<img width=\"1275\"
alt=\"Screenshot 2024-12-12 at 17 19
58\"\r\nsrc=\"https://github.com/user-attachments/assets/2ad14305-15c0-4522-8e70-5691c50e381b\"\r\n/>\r\n\r\nAdds
some bits to the stream overview page:\r\n* Number of docs for the
current time range (let's stop here and don't\r\nbuild more of
Kibana)\r\n* List of child streams for wired streams\r\n* Quick links
tab (currently empty)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"58d1522bfd7e711e6093333dc29e16d1464ad2d0","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","v8.18.0","Feature:Streams"],"title":"🌊
Stream overview
page","number":204079,"url":"https://github.com/elastic/kibana/pull/204079","mergeCommit":{"message":"🌊
Stream overview page (#204079)\n\nStacked on
https://github.com/elastic/kibana/pull/204004\r\n\r\n<img width=\"1275\"
alt=\"Screenshot 2024-12-12 at 17 19
58\"\r\nsrc=\"https://github.com/user-attachments/assets/2ad14305-15c0-4522-8e70-5691c50e381b\"\r\n/>\r\n\r\nAdds
some bits to the stream overview page:\r\n* Number of docs for the
current time range (let's stop here and don't\r\nbuild more of
Kibana)\r\n* List of child streams for wired streams\r\n* Quick links
tab (currently empty)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"58d1522bfd7e711e6093333dc29e16d1464ad2d0"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204079","number":204079,"mergeCommit":{"message":"🌊
Stream overview page (#204079)\n\nStacked on
https://github.com/elastic/kibana/pull/204004\r\n\r\n<img width=\"1275\"
alt=\"Screenshot 2024-12-12 at 17 19
58\"\r\nsrc=\"https://github.com/user-attachments/assets/2ad14305-15c0-4522-8e70-5691c50e381b\"\r\n/>\r\n\r\nAdds
some bits to the stream overview page:\r\n* Number of docs for the
current time range (let's stop here and don't\r\nbuild more of
Kibana)\r\n* List of child streams for wired streams\r\n* Quick links
tab (currently empty)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"58d1522bfd7e711e6093333dc29e16d1464ad2d0"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Joe Reuter <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Jan 13, 2025
Stacked on elastic#204004

<img width="1275" alt="Screenshot 2024-12-12 at 17 19 58"
src="https://github.com/user-attachments/assets/2ad14305-15c0-4522-8e70-5691c50e381b"
/>

Adds some bits to the stream overview page:
* Number of docs for the current time range (let's stop here and don't
build more of Kibana)
* List of child streams for wired streams
* Quick links tab (currently empty)

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Streams This is the label for the Streams Project release_note:skip Skip the PR/issue when compiling release notes v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants