[Security Solution] Test plan for prebuilt rule customization #204888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dplumlee
added
test-plan
v9.0.0
Team:Detections and Resp
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management) |
dplumlee
added
the
release_note:skip
|
@pborgonovi Please review this one |
maximpn
reviewed
Dec 31, 2024
There was a problem hiding this comment.
@dplumlee Thanks for adding Prebuilt Rules Customization test plan 🙏
I reviewed the test plan and left suggestions to make the test plan more robust and improve readability.
It looks like this test plan should include the following scenarios as well
- A test scenario (with examples) for each field affecting isCustomized
- Custom rules shouldn't have "Modified" badge on rule details page
- Custom rules shouldn't have "Modified" badge on rule management table
- Scenarios covering
ruleSource - Users can navigate to rule edit page from prebuilt rule details
Feel free to reach me to discuss it over Zoom in case of questions.
...ity_solution/docs/testing/test_plans/detection_response/prebuilt_rules/rule_customization.md
Outdated
Show resolved
Hide resolved
...ity_solution/docs/testing/test_plans/detection_response/prebuilt_rules/rule_customization.md
Outdated
Show resolved
Hide resolved
...ity_solution/docs/testing/test_plans/detection_response/prebuilt_rules/rule_customization.md
Outdated
Show resolved
Hide resolved
...ity_solution/docs/testing/test_plans/detection_response/prebuilt_rules/rule_customization.md
Outdated
Show resolved
Hide resolved
...ity_solution/docs/testing/test_plans/detection_response/prebuilt_rules/rule_customization.md
Outdated
Show resolved
Hide resolved
...ity_solution/docs/testing/test_plans/detection_response/prebuilt_rules/rule_customization.md
Outdated
Show resolved
Hide resolved
|
|
||
| ### Terminology | ||
|
|
||
| - **Base version**: The version of the rule we ship with the rule package, can be thought of as the "original" version of the rule. |
There was a problem hiding this comment.
Suggested change
| - **Base version**: The version of the rule we ship with the rule package, can be thought of as the "original" version of the rule. | |
| - **Base version**: Prebuilt rule asset we ship in the rule package corresponding to the currently installed prebuilt rules. It represents "original" version of the rule. During prebuilt rules installation prebuilt rule assets data is copied over and becomes an installed prebuilt rule. |
There was a problem hiding this comment.
Can we say that it's a prebuilt rule asset whose "version" field matches the "version" of an installed rule? WDYT?
...ity_solution/docs/testing/test_plans/detection_response/prebuilt_rules/rule_customization.md
Outdated
Show resolved
Hide resolved
...ity_solution/docs/testing/test_plans/detection_response/prebuilt_rules/rule_customization.md
Outdated
Show resolved
Hide resolved
...ity_solution/docs/testing/test_plans/detection_response/prebuilt_rules/rule_customization.md
Outdated
Show resolved
Hide resolved
nikitaindik
reviewed
Jan 7, 2025
...ity_solution/docs/testing/test_plans/detection_response/prebuilt_rules/rule_customization.md
Outdated
Show resolved
Hide resolved
nikitaindik
reviewed
Jan 7, 2025
There was a problem hiding this comment.
Thanks for the PR, @dplumlee! Overall, the test coverage looks solid. I’ve left a couple of comments for you to consider.
One potential improvement: should we add a scenario to ensure that the “Edit” buttons in the rule details page and rule management table are clickable when the feature flag is enabled?
Additionally, do we want to include a test to verify that non-modifiable fields, such as version and id are uneditable?”
Looking forward to your thoughts!
|
@maximpn @nikitaindik I believe I addressed most of your comments or left questions, take a look when you can.
@maximpn I think all the additional test cases you mentioned have now been covered but not sure what you meant by this one. I've left a few responses in regard to the |
nikitaindik
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Thanks for addressing my feedback, @dplumlee! The test plan looks good to me now.
pborgonovi
reviewed
Jan 13, 2025
...ity_solution/docs/testing/test_plans/detection_response/prebuilt_rules/rule_customization.md
Outdated
Show resolved
Hide resolved
...ity_solution/docs/testing/test_plans/detection_response/prebuilt_rules/rule_customization.md
Outdated
Show resolved
Hide resolved
...ity_solution/docs/testing/test_plans/detection_response/prebuilt_rules/rule_customization.md
Outdated
Show resolved
Hide resolved
...ity_solution/docs/testing/test_plans/detection_response/prebuilt_rules/rule_customization.md
Outdated
Show resolved
Hide resolved
...ity_solution/docs/testing/test_plans/detection_response/prebuilt_rules/rule_customization.md
Outdated
Show resolved
Hide resolved
...ity_solution/docs/testing/test_plans/detection_response/prebuilt_rules/rule_customization.md
Outdated
Show resolved
Hide resolved
...ity_solution/docs/testing/test_plans/detection_response/prebuilt_rules/rule_customization.md
Outdated
Show resolved
Hide resolved
...ity_solution/docs/testing/test_plans/detection_response/prebuilt_rules/rule_customization.md
Outdated
Show resolved
Hide resolved
...ity_solution/docs/testing/test_plans/detection_response/prebuilt_rules/rule_customization.md
Outdated
Show resolved
Hide resolved
maximpn
approved these changes
Jan 15, 2025
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 16, 2025
…c#204888) ## Summary Addresses elastic#202068 Adds test plan for rule customization features related to the milestone 3 prebuilt rule customization epic (cherry picked from commit ded92cf)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 16, 2025
…204888) (#206970) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Test plan for prebuilt rule customization (#204888)](#204888) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Davis Plumlee","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-16T15:57:17Z","message":"[Security Solution] Test plan for prebuilt rule customization (#204888)\n\n## Summary\r\n\r\nAddresses https://github.com/elastic/kibana/issues/202068\r\n\r\nAdds test plan for rule customization features related to the milestone\r\n3 prebuilt rule customization epic","sha":"ded92cf9953742e569d6f84850f20de861cb5844","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","test-plan","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v8.18.0"],"title":"[Security Solution] Test plan for prebuilt rule customization","number":204888,"url":"https://github.com/elastic/kibana/pull/204888","mergeCommit":{"message":"[Security Solution] Test plan for prebuilt rule customization (#204888)\n\n## Summary\r\n\r\nAddresses https://github.com/elastic/kibana/issues/202068\r\n\r\nAdds test plan for rule customization features related to the milestone\r\n3 prebuilt rule customization epic","sha":"ded92cf9953742e569d6f84850f20de861cb5844"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204888","number":204888,"mergeCommit":{"message":"[Security Solution] Test plan for prebuilt rule customization (#204888)\n\n## Summary\r\n\r\nAddresses https://github.com/elastic/kibana/issues/202068\r\n\r\nAdds test plan for rule customization features related to the milestone\r\n3 prebuilt rule customization epic","sha":"ded92cf9953742e569d6f84850f20de861cb5844"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Davis Plumlee <[email protected]>
5 tasks
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
…c#204888) ## Summary Addresses elastic#202068 Adds test plan for rule customization features related to the milestone 3 prebuilt rule customization epic
12 tasks
4 tasks
banderror
pushed a commit
that referenced
this pull request
Feb 24, 2025
#207016) ## Summary Adds tests in accordance to #204888 Adds integration tests for the prebuilt rule customization features ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] 🟢 ESS x100: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7919 - [x] 🟡 Serverless x100: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7920 - [x] 🟡 Serverless x100 https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7927 --------- Co-authored-by: Elastic Machine <[email protected]>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 24, 2025
elastic#207016) ## Summary Adds tests in accordance to elastic#204888 Adds integration tests for the prebuilt rule customization features ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] 🟢 ESS x100: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7919 - [x] 🟡 Serverless x100: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7920 - [x] 🟡 Serverless x100 https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7927 --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit a51e96e)
kibanamachine
added a commit
that referenced
this pull request
Feb 24, 2025
…n tests (#207016) (#212253) # Backport This will backport the following commits from `main` to `9.0`: - [[Security Solution] Adds prebuilt rule customization integration tests (#207016)](#207016) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Davis Plumlee","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-24T14:35:17Z","message":"[Security Solution] Adds prebuilt rule customization integration tests (#207016)\n\n## Summary\n\nAdds tests in accordance to\nhttps://github.com//pull/204888\n\nAdds integration tests for the prebuilt rule customization features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7919\n- [x] 🟡 Serverless x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7920\n- [x] 🟡 Serverless x100\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7927\n\n---------\n\nCo-authored-by: Elastic Machine <[email protected]>","sha":"a51e96eae2904aa3488af1037d87d83beec2cd0d","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Adds prebuilt rule customization integration tests","number":207016,"url":"https://github.com/elastic/kibana/pull/207016","mergeCommit":{"message":"[Security Solution] Adds prebuilt rule customization integration tests (#207016)\n\n## Summary\n\nAdds tests in accordance to\nhttps://github.com//pull/204888\n\nAdds integration tests for the prebuilt rule customization features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7919\n- [x] 🟡 Serverless x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7920\n- [x] 🟡 Serverless x100\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7927\n\n---------\n\nCo-authored-by: Elastic Machine <[email protected]>","sha":"a51e96eae2904aa3488af1037d87d83beec2cd0d"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/207016","number":207016,"mergeCommit":{"message":"[Security Solution] Adds prebuilt rule customization integration tests (#207016)\n\n## Summary\n\nAdds tests in accordance to\nhttps://github.com//pull/204888\n\nAdds integration tests for the prebuilt rule customization features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7919\n- [x] 🟡 Serverless x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7920\n- [x] 🟡 Serverless x100\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7927\n\n---------\n\nCo-authored-by: Elastic Machine <[email protected]>","sha":"a51e96eae2904aa3488af1037d87d83beec2cd0d"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Davis Plumlee <[email protected]>
banderror
pushed a commit
that referenced
this pull request
Feb 24, 2025
…212170) **Partially addresses:** #202068 ## Summary Adds tests in accordance to #204888 Follow-up to #207016 Adds cypress tests for the prebuilt rule customization features ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] 🟢 ESS x50: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7925 - [x] 🟢 Serverless x50: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7926
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 24, 2025
…lastic#212170) **Partially addresses:** elastic#202068 ## Summary Adds tests in accordance to elastic#204888 Follow-up to elastic#207016 Adds cypress tests for the prebuilt rule customization features ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] 🟢 ESS x50: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7925 - [x] 🟢 Serverless x50: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7926 (cherry picked from commit ca6cc75)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 24, 2025
…lastic#212170) **Partially addresses:** elastic#202068 ## Summary Adds tests in accordance to elastic#204888 Follow-up to elastic#207016 Adds cypress tests for the prebuilt rule customization features ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] 🟢 ESS x50: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7925 - [x] 🟢 Serverless x50: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7926 (cherry picked from commit ca6cc75)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 24, 2025
…lastic#212170) **Partially addresses:** elastic#202068 ## Summary Adds tests in accordance to elastic#204888 Follow-up to elastic#207016 Adds cypress tests for the prebuilt rule customization features ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] 🟢 ESS x50: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7925 - [x] 🟢 Serverless x50: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7926 (cherry picked from commit ca6cc75)
kibanamachine
added a commit
that referenced
this pull request
Feb 24, 2025
…sts (#212170) (#212297) # Backport This will backport the following commits from `main` to `9.0`: - [[Security Solution] Adds prebuilt rule customization cypress tests (#212170)](#212170) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Davis Plumlee","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-24T18:35:21Z","message":"[Security Solution] Adds prebuilt rule customization cypress tests (#212170)\n\n**Partially addresses:** https://github.com/elastic/kibana/issues/202068\n\n## Summary\n\nAdds tests in accordance to\nhttps://github.com//pull/204888\n\nFollow-up to https://github.com/elastic/kibana/pull/207016\n\nAdds cypress tests for the prebuilt rule customization features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7925\n- [x] 🟢 Serverless x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7926","sha":"ca6cc7520b09f7fd5c455cd9935d80d3f16af1fc","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Adds prebuilt rule customization cypress tests","number":212170,"url":"https://github.com/elastic/kibana/pull/212170","mergeCommit":{"message":"[Security Solution] Adds prebuilt rule customization cypress tests (#212170)\n\n**Partially addresses:** https://github.com/elastic/kibana/issues/202068\n\n## Summary\n\nAdds tests in accordance to\nhttps://github.com//pull/204888\n\nFollow-up to https://github.com/elastic/kibana/pull/207016\n\nAdds cypress tests for the prebuilt rule customization features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7925\n- [x] 🟢 Serverless x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7926","sha":"ca6cc7520b09f7fd5c455cd9935d80d3f16af1fc"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212170","number":212170,"mergeCommit":{"message":"[Security Solution] Adds prebuilt rule customization cypress tests (#212170)\n\n**Partially addresses:** https://github.com/elastic/kibana/issues/202068\n\n## Summary\n\nAdds tests in accordance to\nhttps://github.com//pull/204888\n\nFollow-up to https://github.com/elastic/kibana/pull/207016\n\nAdds cypress tests for the prebuilt rule customization features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7925\n- [x] 🟢 Serverless x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7926","sha":"ca6cc7520b09f7fd5c455cd9935d80d3f16af1fc"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Davis Plumlee <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Feb 24, 2025
…sts (#212170) (#212296) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Adds prebuilt rule customization cypress tests (#212170)](#212170) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Davis Plumlee","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-24T18:35:21Z","message":"[Security Solution] Adds prebuilt rule customization cypress tests (#212170)\n\n**Partially addresses:** https://github.com/elastic/kibana/issues/202068\n\n## Summary\n\nAdds tests in accordance to\nhttps://github.com//pull/204888\n\nFollow-up to https://github.com/elastic/kibana/pull/207016\n\nAdds cypress tests for the prebuilt rule customization features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7925\n- [x] 🟢 Serverless x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7926","sha":"ca6cc7520b09f7fd5c455cd9935d80d3f16af1fc","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Adds prebuilt rule customization cypress tests","number":212170,"url":"https://github.com/elastic/kibana/pull/212170","mergeCommit":{"message":"[Security Solution] Adds prebuilt rule customization cypress tests (#212170)\n\n**Partially addresses:** https://github.com/elastic/kibana/issues/202068\n\n## Summary\n\nAdds tests in accordance to\nhttps://github.com//pull/204888\n\nFollow-up to https://github.com/elastic/kibana/pull/207016\n\nAdds cypress tests for the prebuilt rule customization features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7925\n- [x] 🟢 Serverless x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7926","sha":"ca6cc7520b09f7fd5c455cd9935d80d3f16af1fc"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212170","number":212170,"mergeCommit":{"message":"[Security Solution] Adds prebuilt rule customization cypress tests (#212170)\n\n**Partially addresses:** https://github.com/elastic/kibana/issues/202068\n\n## Summary\n\nAdds tests in accordance to\nhttps://github.com//pull/204888\n\nFollow-up to https://github.com/elastic/kibana/pull/207016\n\nAdds cypress tests for the prebuilt rule customization features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7925\n- [x] 🟢 Serverless x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7926","sha":"ca6cc7520b09f7fd5c455cd9935d80d3f16af1fc"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Davis Plumlee <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Feb 24, 2025
…ests (#212170) (#212295) # Backport This will backport the following commits from `main` to `8.18`: - [[Security Solution] Adds prebuilt rule customization cypress tests (#212170)](#212170) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Davis Plumlee","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-24T18:35:21Z","message":"[Security Solution] Adds prebuilt rule customization cypress tests (#212170)\n\n**Partially addresses:** https://github.com/elastic/kibana/issues/202068\n\n## Summary\n\nAdds tests in accordance to\nhttps://github.com//pull/204888\n\nFollow-up to https://github.com/elastic/kibana/pull/207016\n\nAdds cypress tests for the prebuilt rule customization features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7925\n- [x] 🟢 Serverless x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7926","sha":"ca6cc7520b09f7fd5c455cd9935d80d3f16af1fc","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Adds prebuilt rule customization cypress tests","number":212170,"url":"https://github.com/elastic/kibana/pull/212170","mergeCommit":{"message":"[Security Solution] Adds prebuilt rule customization cypress tests (#212170)\n\n**Partially addresses:** https://github.com/elastic/kibana/issues/202068\n\n## Summary\n\nAdds tests in accordance to\nhttps://github.com//pull/204888\n\nFollow-up to https://github.com/elastic/kibana/pull/207016\n\nAdds cypress tests for the prebuilt rule customization features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7925\n- [x] 🟢 Serverless x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7926","sha":"ca6cc7520b09f7fd5c455cd9935d80d3f16af1fc"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212170","number":212170,"mergeCommit":{"message":"[Security Solution] Adds prebuilt rule customization cypress tests (#212170)\n\n**Partially addresses:** https://github.com/elastic/kibana/issues/202068\n\n## Summary\n\nAdds tests in accordance to\nhttps://github.com//pull/204888\n\nFollow-up to https://github.com/elastic/kibana/pull/207016\n\nAdds cypress tests for the prebuilt rule customization features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7925\n- [x] 🟢 Serverless x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7926","sha":"ca6cc7520b09f7fd5c455cd9935d80d3f16af1fc"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Davis Plumlee <[email protected]>
dplumlee
added a commit
to dplumlee/kibana
that referenced
this pull request
Feb 24, 2025
elastic#207016) ## Summary Adds tests in accordance to elastic#204888 Adds integration tests for the prebuilt rule customization features ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] 🟢 ESS x100: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7919 - [x] 🟡 Serverless x100: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7920 - [x] 🟡 Serverless x100 https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7927 --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit a51e96e)
dplumlee
added a commit
that referenced
this pull request
Feb 25, 2025
…n tests (#207016) (#212313) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Adds prebuilt rule customization integration tests (#207016)](#207016) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Davis Plumlee","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-24T14:35:17Z","message":"[Security Solution] Adds prebuilt rule customization integration tests (#207016)\n\n## Summary\n\nAdds tests in accordance to\nhttps://github.com//pull/204888\n\nAdds integration tests for the prebuilt rule customization features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7919\n- [x] 🟡 Serverless x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7920\n- [x] 🟡 Serverless x100\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7927\n\n---------\n\nCo-authored-by: Elastic Machine <[email protected]>","sha":"a51e96eae2904aa3488af1037d87d83beec2cd0d","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Adds prebuilt rule customization integration tests","number":207016,"url":"https://github.com/elastic/kibana/pull/207016","mergeCommit":{"message":"[Security Solution] Adds prebuilt rule customization integration tests (#207016)\n\n## Summary\n\nAdds tests in accordance to\nhttps://github.com//pull/204888\n\nAdds integration tests for the prebuilt rule customization features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7919\n- [x] 🟡 Serverless x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7920\n- [x] 🟡 Serverless x100\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7927\n\n---------\n\nCo-authored-by: Elastic Machine <[email protected]>","sha":"a51e96eae2904aa3488af1037d87d83beec2cd0d"}},"sourceBranch":"main","suggestedTargetBranches":["8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/212253","number":212253,"state":"MERGED","mergeCommit":{"sha":"c8beef4b9608465b14a097d8ab5fecb8fffbff5b","message":"[9.0] [Security Solution] Adds prebuilt rule customization integration tests (#207016) (#212253)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.0`:\n- [[Security Solution] Adds prebuilt rule customization integration\ntests (#207016)](https://github.com/elastic/kibana/pull/207016)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Davis Plumlee <[email protected]>"}},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/207016","number":207016,"mergeCommit":{"message":"[Security Solution] Adds prebuilt rule customization integration tests (#207016)\n\n## Summary\n\nAdds tests in accordance to\nhttps://github.com//pull/204888\n\nAdds integration tests for the prebuilt rule customization features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7919\n- [x] 🟡 Serverless x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7920\n- [x] 🟡 Serverless x100\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7927\n\n---------\n\nCo-authored-by: Elastic Machine <[email protected]>","sha":"a51e96eae2904aa3488af1037d87d83beec2cd0d"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
dplumlee
added a commit
that referenced
this pull request
Feb 25, 2025
…on tests (#207016) (#212314) # Backport This will backport the following commits from `main` to `8.18`: - [[Security Solution] Adds prebuilt rule customization integration tests (#207016)](#207016) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Davis Plumlee","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-24T14:35:17Z","message":"[Security Solution] Adds prebuilt rule customization integration tests (#207016)\n\n## Summary\n\nAdds tests in accordance to\nhttps://github.com//pull/204888\n\nAdds integration tests for the prebuilt rule customization features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7919\n- [x] 🟡 Serverless x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7920\n- [x] 🟡 Serverless x100\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7927\n\n---------\n\nCo-authored-by: Elastic Machine <[email protected]>","sha":"a51e96eae2904aa3488af1037d87d83beec2cd0d","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Adds prebuilt rule customization integration tests","number":207016,"url":"https://github.com/elastic/kibana/pull/207016","mergeCommit":{"message":"[Security Solution] Adds prebuilt rule customization integration tests (#207016)\n\n## Summary\n\nAdds tests in accordance to\nhttps://github.com//pull/204888\n\nAdds integration tests for the prebuilt rule customization features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7919\n- [x] 🟡 Serverless x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7920\n- [x] 🟡 Serverless x100\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7927\n\n---------\n\nCo-authored-by: Elastic Machine <[email protected]>","sha":"a51e96eae2904aa3488af1037d87d83beec2cd0d"}},"sourceBranch":"main","suggestedTargetBranches":["8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/212253","number":212253,"state":"MERGED","mergeCommit":{"sha":"c8beef4b9608465b14a097d8ab5fecb8fffbff5b","message":"[9.0] [Security Solution] Adds prebuilt rule customization integration tests (#207016) (#212253)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.0`:\n- [[Security Solution] Adds prebuilt rule customization integration\ntests (#207016)](https://github.com/elastic/kibana/pull/207016)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Davis Plumlee <[email protected]>"}},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/207016","number":207016,"mergeCommit":{"message":"[Security Solution] Adds prebuilt rule customization integration tests (#207016)\n\n## Summary\n\nAdds tests in accordance to\nhttps://github.com//pull/204888\n\nAdds integration tests for the prebuilt rule customization features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7919\n- [x] 🟡 Serverless x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7920\n- [x] 🟡 Serverless x100\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7927\n\n---------\n\nCo-authored-by: Elastic Machine <[email protected]>","sha":"a51e96eae2904aa3488af1037d87d83beec2cd0d"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
Feb 25, 2025
…lastic#212170) **Partially addresses:** elastic#202068 ## Summary Adds tests in accordance to elastic#204888 Follow-up to elastic#207016 Adds cypress tests for the prebuilt rule customization features ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] 🟢 ESS x50: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7925 - [x] 🟢 Serverless x50: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7926
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Feb 27, 2025
elastic#207016) ## Summary Adds tests in accordance to elastic#204888 Adds integration tests for the prebuilt rule customization features ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] 🟢 ESS x100: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7919 - [x] 🟡 Serverless x100: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7920 - [x] 🟡 Serverless x100 https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7927 --------- Co-authored-by: Elastic Machine <[email protected]>
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Feb 27, 2025
…lastic#212170) **Partially addresses:** elastic#202068 ## Summary Adds tests in accordance to elastic#204888 Follow-up to elastic#207016 Adds cypress tests for the prebuilt rule customization features ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] 🟢 ESS x50: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7925 - [x] 🟢 Serverless x50: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7926
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Mar 4, 2025
…sts (elastic#212170) (elastic#212296) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Adds prebuilt rule customization cypress tests (elastic#212170)](elastic#212170) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Davis Plumlee","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-24T18:35:21Z","message":"[Security Solution] Adds prebuilt rule customization cypress tests (elastic#212170)\n\n**Partially addresses:** https://github.com/elastic/kibana/issues/202068\n\n## Summary\n\nAdds tests in accordance to\nhttps://github.com/elastic/pull/204888\n\nFollow-up to https://github.com/elastic/kibana/pull/207016\n\nAdds cypress tests for the prebuilt rule customization features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7925\n- [x] 🟢 Serverless x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7926","sha":"ca6cc7520b09f7fd5c455cd9935d80d3f16af1fc","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Adds prebuilt rule customization cypress tests","number":212170,"url":"https://github.com/elastic/kibana/pull/212170","mergeCommit":{"message":"[Security Solution] Adds prebuilt rule customization cypress tests (elastic#212170)\n\n**Partially addresses:** https://github.com/elastic/kibana/issues/202068\n\n## Summary\n\nAdds tests in accordance to\nhttps://github.com/elastic/pull/204888\n\nFollow-up to https://github.com/elastic/kibana/pull/207016\n\nAdds cypress tests for the prebuilt rule customization features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7925\n- [x] 🟢 Serverless x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7926","sha":"ca6cc7520b09f7fd5c455cd9935d80d3f16af1fc"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212170","number":212170,"mergeCommit":{"message":"[Security Solution] Adds prebuilt rule customization cypress tests (elastic#212170)\n\n**Partially addresses:** https://github.com/elastic/kibana/issues/202068\n\n## Summary\n\nAdds tests in accordance to\nhttps://github.com/elastic/pull/204888\n\nFollow-up to https://github.com/elastic/kibana/pull/207016\n\nAdds cypress tests for the prebuilt rule customization features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7925\n- [x] 🟢 Serverless x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7926","sha":"ca6cc7520b09f7fd5c455cd9935d80d3f16af1fc"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Davis Plumlee <[email protected]>
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Mar 4, 2025
…n tests (elastic#207016) (elastic#212313) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Adds prebuilt rule customization integration tests (elastic#207016)](elastic#207016) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Davis Plumlee","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-24T14:35:17Z","message":"[Security Solution] Adds prebuilt rule customization integration tests (elastic#207016)\n\n## Summary\n\nAdds tests in accordance to\nhttps://github.com/elastic/pull/204888\n\nAdds integration tests for the prebuilt rule customization features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7919\n- [x] 🟡 Serverless x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7920\n- [x] 🟡 Serverless x100\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7927\n\n---------\n\nCo-authored-by: Elastic Machine <[email protected]>","sha":"a51e96eae2904aa3488af1037d87d83beec2cd0d","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Adds prebuilt rule customization integration tests","number":207016,"url":"https://github.com/elastic/kibana/pull/207016","mergeCommit":{"message":"[Security Solution] Adds prebuilt rule customization integration tests (elastic#207016)\n\n## Summary\n\nAdds tests in accordance to\nhttps://github.com/elastic/pull/204888\n\nAdds integration tests for the prebuilt rule customization features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7919\n- [x] 🟡 Serverless x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7920\n- [x] 🟡 Serverless x100\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7927\n\n---------\n\nCo-authored-by: Elastic Machine <[email protected]>","sha":"a51e96eae2904aa3488af1037d87d83beec2cd0d"}},"sourceBranch":"main","suggestedTargetBranches":["8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/212253","number":212253,"state":"MERGED","mergeCommit":{"sha":"c8beef4b9608465b14a097d8ab5fecb8fffbff5b","message":"[9.0] [Security Solution] Adds prebuilt rule customization integration tests (elastic#207016) (elastic#212253)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.0`:\n- [[Security Solution] Adds prebuilt rule customization integration\ntests (elastic#207016)](https://github.com/elastic/kibana/pull/207016)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Davis Plumlee <[email protected]>"}},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/207016","number":207016,"mergeCommit":{"message":"[Security Solution] Adds prebuilt rule customization integration tests (elastic#207016)\n\n## Summary\n\nAdds tests in accordance to\nhttps://github.com/elastic/pull/204888\n\nAdds integration tests for the prebuilt rule customization features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7919\n- [x] 🟡 Serverless x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7920\n- [x] 🟡 Serverless x100\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7927\n\n---------\n\nCo-authored-by: Elastic Machine <[email protected]>","sha":"a51e96eae2904aa3488af1037d87d83beec2cd0d"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #202068
Adds test plan for rule customization features related to the milestone 3 prebuilt rule customization epic