Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Improve text strings in new agent binary download section #204988

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Supplementing
Copy link
Contributor

Summary

Closes #139151

Changed placeholder and help text to be more descriptive (using approved text from issue).

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

n/a

@Supplementing Supplementing added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Fleet Team label for Observability Data Collection Fleet team labels Dec 19, 2024
@Supplementing Supplementing requested a review from a team as a code owner December 19, 2024 17:44
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@nchaulet
Copy link
Member

@Supplementing when deleting a translation key, you will have to delete the related translations, this could be done automatically by running node scripts/i18n_check.js --fix in your kibana directory

@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 19, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #9 / EditOutputFlyout should render the flyout if there is no download source provided
  • [job] [logs] Jest Tests #9 / EditOutputFlyout should render the flyout if there is no download source provided

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.7MB 1.7MB -82.0B

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve text strings in new agent binary download section
3 participants