Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Improve text strings in new agent binary download section #204988

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+6 −14
Open

[Fleet] Improve text strings in new agent binary download section #204988

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7c48667
placeholder and helper text with approved text
Supplementing Dec 19, 2024
a321c1c
removed translation on placeholder as its a url and translation isnt …
Supplementing Dec 19, 2024
7eb94f0
removed trailing slash that breaks url in placeholder
Supplementing Dec 19, 2024
dac914c
realized last commit was actually incorrect, the trailing slash is ne…
Supplementing Dec 19, 2024
6150c0d
removed translations no longer needed
Supplementing Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...t/public/applications/fleet/sections/settings/components/download_source_flyout/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ export const EditDownloadSourceFlyout: React.FunctionComponent<EditDownloadSourc
<FormattedMessage
data-test-subj="editDownloadSourcesFlyout.hostHelpText"
id="xpack.fleet.settings.editDownloadSourcesFlyout.hostsInputDescription"
defaultMessage="Address that your agents will use to download their binary from. Specify the path to the directory containing the binary. {guideLink}"
defaultMessage="Enter the address of the directory containing the binaries to download. {guideLink}"
values={{
guideLink: (
<EuiLink href={docLinks.links.fleet.settings} target="_blank" external>
Expand Down Expand Up @@ -132,7 +132,7 @@ export const EditDownloadSourceFlyout: React.FunctionComponent<EditDownloadSourc
placeholder={i18n.translate(
Supplementing marked this conversation as resolved.
Show resolved Hide resolved
'xpack.fleet.settings.editDownloadSourcesFlyout.hostsInputPlaceholder',
{
defaultMessage: 'Specify host',
defaultMessage: 'https://artifacts.elastic.co/downloads/',
}
)}
/>
Expand Down
2 changes: 1 addition & 1 deletion ...ic/applications/fleet/sections/settings/components/settings_page/agent_binary_section.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export const AgentBinarySection: React.FunctionComponent<AgentBinarySectionProps
<EuiText color="subdued" size="m">
<FormattedMessage
id="xpack.fleet.settings.downloadSourcesSection.Subtitle"
defaultMessage="Specify where the agents will download their binary from. Checked default will apply to all policies unless overwritten."
defaultMessage="List of sources used by Elastic agents to download their binaries. The default source applies to all agent policies that don't have a specific binary source specified."
/>
</EuiText>
<EuiSpacer size="m" />
Expand Down