WRQ-17933: Add unit tests for screenTypes matching supported resolutions

[vJIYEv]

Checklist

• I have read and understand the contribution guide
• A CHANGELOG entry is included
• At least one test case is included for this feature or bug fix
• Documentation was added or is not needed
• This is an API breaking change

Issue Resolved / Feature Added

As we support new resolution type QHD, we decided to test all supported screen types.

Resolution

Added QHD type in screenTypes.json file. (enactjs/sandstone#1596)
And added unit tests for screenTypes of supported resolutions.

Additional Considerations

Links

WRQ-17933

Comments

Enact-DCO-1.0-Signed-off-by: Jiye Kim ([email protected])

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.41%. Comparing base (da7050c) to head (05bd06e).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3228      +/-   ##
===========================================
+ Coverage    82.36%   82.41%   +0.04%     
===========================================
  Files          156      156              
  Lines         7209     7209              
  Branches      1907     1907              
===========================================
+ Hits          5938     5941       +3     
+ Misses         999      997       -2     
+ Partials       272      271       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mmyelyn]

Just to add one comment, when specifying sizes, including resolution, we typically use the order width x height. So I think it would be a good idea to have these unit tests in that order as well.

[mmyelyn]

Good

[vJIYEv]

I changed height x width to width x height.

[juwonjeong]

@vJIYEv, Please add more cases(QHD and UHD) to the 'should calculate the base font size for the given screen type' test.

[juwonjeong]

LGTM