Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRQ-17933: Support QHD resolution #1596

Merged
merged 1 commit into from
May 3, 2024
Merged

WRQ-17933: Support QHD resolution #1596

merged 1 commit into from
May 3, 2024

Conversation

vJIYEv
Copy link
Contributor

@vJIYEv vJIYEv commented Apr 23, 2024

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

We need to support QHD resolution for TV.

Resolution

Added QHD type in screenTypes.json file.
And also added unit tests for screenTypes of supported resolutions. (enactjs/enact#3228)

Additional Considerations

Links

WRQ-17933

Comments

Enact-DCO-1.0-Signed-off-by: Jiye Kim ([email protected])

Enact-DCO-1.0-Signed-off-by: Jiye Kim ([email protected])
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.45%. Comparing base (8272859) to head (09aeea3).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1596   +/-   ##
========================================
  Coverage    81.45%   81.45%           
========================================
  Files          148      148           
  Lines         6631     6631           
  Branches      1957     1957           
========================================
  Hits          5401     5401           
  Misses         936      936           
  Partials       294      294           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vJIYEv vJIYEv mentioned this pull request Apr 24, 2024
5 tasks
Copy link
Contributor

@mmyelyn mmyelyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

Copy link
Contributor

@juwonjeong juwonjeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juwonjeong juwonjeong merged commit 612b167 into develop May 3, 2024
7 checks passed
@juwonjeong juwonjeong deleted the feature/WRQ-17933 branch May 3, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants