Changes to support rust-analyzer in a limited fashion at least #2029
Conversation
bugadani
force-pushed
the
ra
branch
2 times, most recently
from
ffaeb4e to
f1041a4
Compare
|
I had just assumed people were writing their own config files, certainly been the case here. FYI we previously had VS Code configuration in the repo but it ended up being a bit of a pain in the ass, it periodically breaks due to |
|
Please note that I'm not checking in any actual config files. I'm trying to provide a quick "rename this"-style template that people can then customize. There are a few unresolved problems I'm still papering over, but I believe that even a partially functional rust-analyzer has a ton of added benefits. |
bugadani
force-pushed
the
ra
branch
5 times, most recently
from
9eb8d63 to
c1daa3b
Compare
|
I'm slightly concerned by the change in output paths. Whatever I took out of |
| @@ -73,15 +73,15 @@ embedded-hal = ["dep:embedded-hal", "dep:embedded-hal-nb"] | |||
| embedded-io = ["dep:embedded-io"] | |||
|
|
|||
| [[example]] | |||
| name = "blinky" | |||
| name = "lp_blinky" | |||
There was a problem hiding this comment.
Renamed because examples are now placed into the same target folder (the workspace's) regardless of the source package.
| .join("target") | ||
| .join(target) | ||
| .join("doc"), | ||
| .join("doc") | ||
| .join(package.to_string().replace('-', "_")), |
There was a problem hiding this comment.
This change means we can't generate documentation for the packages excluded from the workspace. Not sure if it matters, I don't think we want to do that for the xtensa-lx packages or hil tests at this moment.
bugadani
changed the title
There are a few issues (mostly stemming from us lying about the architecture), but I think the benefits outweigh them. And it's still possible to disable rust-analyzer either repo-wise, or per-package, using
excludeDirs.Unfortunately, the cause of the proc-macro pains of this PR is unclear
The biggest change is possibly that now everything is placed into the workspace's target folder, so examples may clash and documentation paths changed.