misc: Remote vs. Local Velox function benchmark #11539
Closed
+353
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D65694860 |
emilysun201309
added a commit
to emilysun201309/velox
that referenced
this pull request
Dec 11, 2024
Summary: Benchmark Velox udfs with Remote function execution vs. local execution. Differential Revision: D65694860
emilysun201309
force-pushed
the
export-D65694860
branch
from
e710e87 to
2137607
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65694860 |
emilysun201309
added a commit
to emilysun201309/velox
that referenced
this pull request
Dec 11, 2024
emilysun201309
force-pushed
the
export-D65694860
branch
from
2137607 to
2135055
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65694860 |
emilysun201309
changed the title
emilysun201309
added a commit
to emilysun201309/velox
that referenced
this pull request
Dec 12, 2024
emilysun201309
force-pushed
the
export-D65694860
branch
from
2135055 to
857d356
Compare
emilysun201309
requested review from
assignUser and
majetideepak
as code owners
|
This pull request was exported from Phabricator. Differential Revision: D65694860 |
pedroerp
reviewed
Dec 13, 2024
emilysun201309
added a commit
to emilysun201309/velox
that referenced
this pull request
Dec 13, 2024
emilysun201309
force-pushed
the
export-D65694860
branch
from
857d356 to
a8fed03
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65694860 |
emilysun201309
added a commit
to emilysun201309/velox
that referenced
this pull request
Dec 13, 2024
emilysun201309
force-pushed
the
export-D65694860
branch
from
a8fed03 to
8af4f13
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65694860 |
emilysun201309
force-pushed
the
export-D65694860
branch
from
8af4f13 to
83574bd
Compare
emilysun201309
added a commit
to emilysun201309/velox
that referenced
this pull request
Dec 13, 2024
|
This pull request was exported from Phabricator. Differential Revision: D65694860 |
…bookincubator#11538) Summary: This diff is to extract the common logic related to starting RemoteFunctionService to a single place, so that we can later reuse it. - Create a Class RemoteFunctionServiceProvider and extract the logic related to starting a local thrift server for RemoteFunctionService there. - Create a Singleton remoteFunctionServiceProviderSingleton so that the server is only started once per process. - Expose helper methods `getRemoteFunctionServiceParamsForLocalThrift()` - Use this in RemoteFunctionTest.cpp Differential Revision: D65927269
emilysun201309
force-pushed
the
export-D65694860
branch
from
83574bd to
1a15cf8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65694860 |
pedroerp
approved these changes
Dec 17, 2024
|
This pull request has been merged in 9b64b94. |
| @@ -15,3 +15,5 @@ | |||
| add_subdirectory(if) | |||
| add_subdirectory(client) | |||
| add_subdirectory(server) | |||
| add_subdirectory(utils) | |||
| add_subdirectory(benchmarks) | |||
There was a problem hiding this comment.
Benchmarks must be enclosed under the VELOX_ENABLE_BENCHMARKS CMake option.
CC: @amitkdutta
@czentgr is opening a fix.
czentgr
added a commit
to czentgr/velox
that referenced
this pull request
Dec 18, 2024
The remote function benchmarks are built without checking if the benchmark utilities are being built. These are only built if certain flags are set. This causes upstream issues in Prestissimo because there remote functions are being built but the benchmarks are not. PR introducing the breaking change: facebookincubator#11539
czentgr
added a commit
to czentgr/velox
that referenced
this pull request
Dec 18, 2024
The remote function benchmarks are built without checking if the benchmark utilities are being built. These are only built if certain flags are set. This causes upstream issues in Prestissimo because there remote functions are being built but the benchmarks are not. PR introducing the breaking change: facebookincubator#11539
czentgr
added a commit
to czentgr/velox
that referenced
this pull request
Dec 18, 2024
The remote function benchmarks are built without checking if the benchmark utilities are being built. These are only built if certain flags are set. This causes upstream issues in Prestissimo because there remote functions are being built but the benchmarks are not. PR introducing the breaking change: facebookincubator#11539
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 18, 2024
Summary: The remote function benchmarks are built without checking if the benchmark utilities are being built. These are only built if certain flags are set. This causes upstream issues in Prestissimo because there remote functions are being built but the benchmarks are not. PR introducing the breaking change: #11539 Pull Request resolved: #11905 Reviewed By: kagamiori Differential Revision: D67403110 Pulled By: kgpai fbshipit-source-id: 62955ddbc540d4397dce094816496c4d87d035a3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Benchmark Velox udfs with Remote function execution vs. local execution.
Differential Revision: D65694860