-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Create utility file for encoding #8650
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for meta-velox canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Joe-Abraham.
Can you write some simple unit tests for this code ? Would really help keep the code quality as well as understand your API.
5992513
to
7f503d1
Compare
@aditi-pandit, I have added the test cases as you suggested. Please have a look. |
53c7327
to
86d7ca6
Compare
4503a3a
to
a3de992
Compare
6ea80b8
to
2345bae
Compare
cb6fca2
to
a17586d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Abe. I have a few comments.
849469f
to
383ca50
Compare
Actually why not put this inside |
@Yuhta, The intention is to use |
@Joe-Abraham Base32 is just variant of Base64 so we should put them in the same utility class. |
@Yuhta,
It would be great if you could review this. |
438539a
to
c175d13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be BaseEncoderUtils
. Also the functions should be put in a class like BaseEncoderUtils
Add a new utility file that shares the common logic for decoding and encoding based on the base variants.
from_base32
andto_base32
#7672) has been raised as subsequent PRs.