Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support PEP604 syntax str | None #168

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Apply suggestions from code review

07a797c
Select commit
Loading
Failed to load commit list.
Open

feat: support PEP604 syntax str | None #168

Apply suggestions from code review
07a797c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jul 19, 2024 in 0s

88.99% (-0.04%) compared to 57f13cc

View this Pull Request on Codecov

88.99% (-0.04%) compared to 57f13cc

Details

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.99%. Comparing base (57f13cc) to head (07a797c).

Files Patch % Lines
fgpyo/util/types.py 86.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #168      +/-   ##
==========================================
- Coverage   89.02%   88.99%   -0.04%     
==========================================
  Files          17       17              
  Lines        2005     2017      +12     
  Branches      437      439       +2     
==========================================
+ Hits         1785     1795      +10     
- Misses        144      145       +1     
- Partials       76       77       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.