Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add test block that duplicates on drag #2377

Merged
merged 1 commit into from
May 31, 2024

Conversation

BeksOmega
Copy link
Contributor

The basics

The details

Resolves

Fixes N/A

Proposed Changes

Adds a test blocks that duplicates on drag so we can ensure we don't regress in support for that functionality.

Test Coverage

Tested that with my local version of Blockly the block duplicates both when it is a real block and when it is a shadow.

Documentation

N/A

Additional Information

N/A

@BeksOmega BeksOmega requested a review from a team as a code owner May 28, 2024 13:26
@BeksOmega BeksOmega requested review from cpcallen and removed request for a team May 28, 2024 13:26
Copy link
Contributor

@cpcallen cpcallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix lint warnings.

Is there (or will there be) a corresponding Blockly to add a test that exercises this functionality? If so, please add a comment to this PR referencing it.

@BeksOmega
Copy link
Contributor Author

I'm not going to fix the lint warnings. imo the code is readable and sufficient for testing. I think for test code it's allowable to ignore the warning - that's why it's not an error.

ATM there's not going to be a test in core exercising this - it will just need to be manually tested. It might be possible to test this with a webdriver test? but dealing with the circular dependencies to get that working is not a high priority for me right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants