Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional ValidatorsResponse cursor #1165

Merged

Conversation

Copy link
Member

@Thoralf-M Thoralf-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thibault-martinez
Copy link
Member Author

thibault-martinez commented Sep 7, 2023

Please also add the optional cursor as parameter https://github.com/iotaledger/tips-draft/pull/24/files#diff-04aff9a5004dd8023df5735c866f69254359635764a00e9d9215500a9676319bR2881-R2883 to get_validators()

I had a look and I think I'll do it in another PR. The query parameter of get_request is not very handy, it forces us to create the param string ourselves. This should take a vector and build the string inside.

@thibault-martinez thibault-martinez merged commit ba7439c into iotaledger:2.0 Sep 11, 2023
19 of 20 checks passed
@thibault-martinez thibault-martinez deleted the validators-optional-cursor branch September 11, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants