Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename verilog-compiler.vhdl to verilog-compiler.yml #9

Merged
merged 5 commits into from
Oct 26, 2023

Conversation

jon011235
Copy link
Owner

@jon011235 jon011235 commented Oct 25, 2023

Correcting a stupid error i made

@jon011235 jon011235 self-assigned this Oct 25, 2023
@jon011235 jon011235 added the Easy Fix Easy to fix label Oct 25, 2023
@jon011235 jon011235 marked this pull request as draft October 25, 2023 18:33
@iJustLeyxo iJustLeyxo self-requested a review October 25, 2023 18:33
@jon011235
Copy link
Owner Author

Requires renaming a directory which fails in the github web gui and i can not load the codesapce in the moment

@jon011235
Copy link
Owner Author

The actions directory needs to be renamed to "workflows"

@iJustLeyxo
Copy link
Collaborator

iJustLeyxo commented Oct 25, 2023

The actions directory needs to be renamed to "workflows"

@jon011235 I can try renaming the directory. Is there a specific way I should do this?

@jon011235
Copy link
Owner Author

The actions directory needs to be renamed to "workflows"

@jon011235 I can try renaming the directory. Is there a specific way I should do this?

No, just rename it. Thanks (Github only searches for github actions in the workflows directory and i remembered the directoy name wrongly)

@iJustLeyxo
Copy link
Collaborator

Done. You can make the push active again.

@jon011235 jon011235 marked this pull request as ready for review October 26, 2023 09:24
@jon011235 jon011235 requested a review from DM8AT October 26, 2023 10:08
Copy link
Collaborator

@DM8AT DM8AT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@jon011235 jon011235 merged commit af16d6e into main Oct 26, 2023
1 check passed
@jon011235 jon011235 deleted the correcting-stupid-error branch October 26, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy Fix Easy to fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants