Added dynamic icons to filters in tools page[Closes #1260] #1309

bhat-shubham · 2025-01-14T07:14:09Z

What kind of change does this PR introduce?
This PR Closes Issue #1260 , adding dynamic and meaningful icons to each and every Filter on the Tools Page.

Issue Number:

Closes 🐛 Bug: All Filters Show The Same "Filter Icon" In The Tools Page #1260

Screenshots/videos:
Before-

After-

If relevant, did you update the documentation?
NA

Summary
Adds dynamic icons to the filters in Tools Page.

Does this PR introduce a breaking change?
NO

NA

github-actions · 2025-01-14T07:16:24Z

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name	Status	Preview	Last Commit
website	✅ Ready (View Log)	Visit Preview	`a111362`

codecov · 2025-01-14T07:17:32Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (27ef6c9) to head (a111362).
Report is 11 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main     #1309   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          387       396    +9     
  Branches       103       106    +3     
=========================================
+ Hits           387       396    +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

benjagm

Can you please revert the changes in the community submodule?

bhat-shubham · 2025-01-20T03:08:20Z

Can you please revert the changes in the community submodule?

Sure Sir! I'll revert the changes.

DarhkVoyd · 2025-01-20T18:18:40Z

_includes/community

Can you please revert the changes in the community submodule?

Yes, i have reverted The Changes.

DarhkVoyd · 2025-01-20T18:19:21Z

components/Sidebar.tsx

How are these changes relevant to the linked issue for Tools Page?

pages/tools/components/Sidebar.tsx

DarhkVoyd · 2025-01-20T18:33:01Z

pages/tools/components/ui/DropdownMenu.tsx

-          { hidden: !isDropdownOpen },
+          'ml-0 mt-0 overflow-hidden transition-all duration-500 ease-in-out',
+          {
+            'max-h-0 opacity-0 invisible': !isDropdownOpen,


Doesn't this make it more complicated?

This reverts commit b41272d.

This reverts commit 8b5c652.

This reverts commit 8e903d7.

DhairyaMajmudar

@bhat-shubham your CI checks are failing pls. fix them, also remove changes from submodule folders

bhat-shubham · 2025-01-26T16:49:06Z

@DhairyaMajmudar I have reverted the changes in the submodule as well as fixed the failing checks.

bhat-shubham · 2025-02-11T14:47:20Z

hey @benjagm @DarhkVoyd I have made the changes you asked for and need suggestion for the one if it needs to be done that way.
Please Review the PR and let me know.

benjagm

LGTM

DarhkVoyd

LGTM!

bhat-shubham · 2025-03-06T17:52:29Z

hey @DarhkVoyd, thank you for approving the changes however, you previously mentioned about the object being redundant and how i could use the filters obj instead.
I have that approach ready as well.
Do Let Me Know if you would like to review it as well.

DarhkVoyd · 2025-03-07T16:33:33Z

hey @DarhkVoyd, thank you for approving the changes however, you previously mentioned about the object being redundant and how i could use the filters obj instead. I have that approach ready as well. Do Let Me Know if you would like to review it as well.

Hey, that's not a big deal. I just suggested instead of separately managing the filterIcons object with filters as keys, we could have just stored them with the existing filters: ex:

const filters = [
    { label: 'Language', accessorKey: 'languages', icon: LanguageIcon },
    ...
];

That would keep the filters data all together and we can just access them during iteration. The filters data as single source of truth. This is fine too. That is just what I would have preferred but that's just my preference.

bhat-shubham · 2025-03-07T17:09:37Z

Got it! @DarhkVoyd , I had mentioned this in a previous review as well, asking if that was the approach you preferred. And it's the same, I won’t be pushing that commit as per your guidance.

bhat-shubham

Marked as not necessary since the changes are approved. Closing the review now.

pages/tools/components/Sidebar.tsx

DhairyaMajmudar

Thanks for PR, just a minor comment, rest we're almost done.

pages/tools/components/Sidebar.tsx

Co-authored-by: Dhairya Majmudar <[email protected]>

DhairyaMajmudar

LGTM 👍🏻

bhat-shubham added 7 commits January 10, 2025 23:00

added dynamic icons to the filter in tools page

723fe15

added dynamic icons to the filter in tools page

02ac24c

added dynamic icons to the filter in tools page

63d02df

added dynamic icons to the filter in tools page

8b5c652

added dynamic icons to the filter in tools page

b41272d

to save before switching

8e903d7

added proper icons to each filter on tools page

3ff4de1

bhat-shubham requested a review from a team as a code owner January 14, 2025 07:14

github-actions bot deployed to Preview January 14, 2025 07:16 View deployment

benjagm requested a review from DarhkVoyd January 19, 2025 12:08

benjagm requested changes Jan 19, 2025

View reviewed changes

DarhkVoyd requested changes Jan 20, 2025

View reviewed changes

bhat-shubham added 4 commits January 23, 2025 13:30

Revert "added dynamic icons to the filter in tools page"

1a79e9c

This reverts commit b41272d.

Revert "added dynamic icons to the filter in tools page"

1641011

This reverts commit 8b5c652.

Revert "to save before switching"

7b8c534

This reverts commit 8e903d7.

reverting changes

42f75f2

DhairyaMajmudar requested changes Jan 23, 2025

View reviewed changes

bhat-shubham added 3 commits January 26, 2025 18:38

reverting the changes in sublodules

71bdeca

revert submodule changes

bd07ca3

fixed prettier errors

c90a0a4

github-actions bot deployed to Preview January 26, 2025 15:09 View deployment

Merge branch 'main' into added_dynamic_icons_to_filter_in_tools_page

14232ce

benjagm requested review from DarhkVoyd, DhairyaMajmudar and benjagm March 4, 2025 08:18

github-actions bot deployed to Preview March 4, 2025 08:20 View deployment

benjagm approved these changes Mar 5, 2025

View reviewed changes

benjagm requested review from DarhkVoyd and removed request for DarhkVoyd March 5, 2025 22:42

DarhkVoyd approved these changes Mar 6, 2025

View reviewed changes

bhat-shubham commented Mar 7, 2025

View reviewed changes

pages/tools/components/Sidebar.tsx Show resolved Hide resolved

DhairyaMajmudar requested changes Mar 10, 2025

View reviewed changes

pages/tools/components/Sidebar.tsx Outdated Show resolved Hide resolved

Removed Irrelevant Icon Check

a111362

Co-authored-by: Dhairya Majmudar <[email protected]>

github-actions bot deployed to Preview March 10, 2025 12:24 View deployment

DhairyaMajmudar approved these changes Mar 11, 2025

View reviewed changes

DhairyaMajmudar added the ready-to-merge PR that already has two approvals. label Mar 11, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added dynamic icons to filters in tools page[Closes #1260] #1309

Added dynamic icons to filters in tools page[Closes #1260] #1309

bhat-shubham commented Jan 14, 2025

github-actions bot commented Jan 14, 2025 •

edited

Loading

codecov bot commented Jan 14, 2025 •

edited

Loading

benjagm left a comment

bhat-shubham commented Jan 20, 2025

DarhkVoyd Jan 20, 2025

bhat-shubham Jan 26, 2025

DarhkVoyd Jan 20, 2025

DarhkVoyd Jan 20, 2025

DhairyaMajmudar left a comment

bhat-shubham commented Jan 26, 2025

bhat-shubham commented Feb 11, 2025

benjagm left a comment

DarhkVoyd left a comment

bhat-shubham commented Mar 6, 2025

DarhkVoyd commented Mar 7, 2025 •

edited

Loading

bhat-shubham commented Mar 7, 2025

bhat-shubham left a comment

DhairyaMajmudar left a comment

DhairyaMajmudar left a comment

Added dynamic icons to filters in tools page[Closes #1260] #1309

Are you sure you want to change the base?

Added dynamic icons to filters in tools page[Closes #1260] #1309

Conversation

bhat-shubham commented Jan 14, 2025

github-actions bot commented Jan 14, 2025 • edited Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

codecov bot commented Jan 14, 2025 • edited Loading

Codecov Report

benjagm left a comment

Choose a reason for hiding this comment

bhat-shubham commented Jan 20, 2025

DarhkVoyd Jan 20, 2025

Choose a reason for hiding this comment

bhat-shubham Jan 26, 2025

Choose a reason for hiding this comment

DarhkVoyd Jan 20, 2025

Choose a reason for hiding this comment

DarhkVoyd Jan 20, 2025

Choose a reason for hiding this comment

DhairyaMajmudar left a comment

Choose a reason for hiding this comment

bhat-shubham commented Jan 26, 2025

bhat-shubham commented Feb 11, 2025

benjagm left a comment

Choose a reason for hiding this comment

DarhkVoyd left a comment

Choose a reason for hiding this comment

bhat-shubham commented Mar 6, 2025

DarhkVoyd commented Mar 7, 2025 • edited Loading

bhat-shubham commented Mar 7, 2025

bhat-shubham left a comment

Choose a reason for hiding this comment

DhairyaMajmudar left a comment

Choose a reason for hiding this comment

DhairyaMajmudar left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 14, 2025 •

edited

Loading

codecov bot commented Jan 14, 2025 •

edited

Loading

DarhkVoyd commented Mar 7, 2025 •

edited

Loading