Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dynamic icons to filters in tools page[Closes #1260] #1309

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
+28 −4
Open

Added dynamic icons to filters in tools page[Closes #1260] #1309

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
723fe15
added dynamic icons to the filter in tools page
bhat-shubham Jan 10, 2025
02ac24c
added dynamic icons to the filter in tools page
bhat-shubham Jan 10, 2025
63d02df
added dynamic icons to the filter in tools page
bhat-shubham Jan 10, 2025
8b5c652
added dynamic icons to the filter in tools page
bhat-shubham Jan 10, 2025
b41272d
added dynamic icons to the filter in tools page
bhat-shubham Jan 10, 2025
8e903d7
to save before switching
bhat-shubham Jan 10, 2025
3ff4de1
added proper icons to each filter on tools page
bhat-shubham Jan 10, 2025
1a79e9c
Revert "added dynamic icons to the filter in tools page"
bhat-shubham Jan 23, 2025
1641011
Revert "added dynamic icons to the filter in tools page"
bhat-shubham Jan 23, 2025
7b8c534
Revert "to save before switching"
bhat-shubham Jan 23, 2025
42f75f2
reverting changes
bhat-shubham Jan 23, 2025
71bdeca
reverting the changes in sublodules
bhat-shubham Jan 26, 2025
bd07ca3
revert submodule changes
bhat-shubham Jan 26, 2025
c90a0a4
fixed prettier errors
bhat-shubham Jan 26, 2025
14232ce
Merge branch 'main' into added_dynamic_icons_to_filter_in_tools_page
benjagm Mar 4, 2025
a111362
Removed Irrelevant Icon Check
bhat-shubham Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Loading
Loading status checks…
added proper icons to each filter on tools page
@bhat-shubham
bhat-shubham committed Jan 10, 2025
commit 3ff4de1867b9e8d059590763d252d7acbbd99222
8 changes: 1 addition & 7 deletions pages/tools/components/Sidebar.tsx
View file
Original file line number Diff line number Diff line change
@@ -97,13 +97,7 @@ export default function Sidebar({
<DropdownMenu
key={accessorKey}
label={label}
icon={
IconComponent && (
<div className='icon-wrapper pr-4'>
<IconComponent />
</div>
)
}
icon={IconComponent && <IconComponent />}
>
{filterCriteria[accessorKey as FilterCriteriaFields]
?.map(String)
2 changes: 1 addition & 1 deletion pages/tools/components/ui/DropdownMenu.tsx
View file
Original file line number Diff line number Diff line change
@@ -26,7 +26,7 @@ export default function DropdownMenu({
}, [router]);

return (
<div className='my-2 bg-slate-200 dark:bg-slate-900 p-2 rounded'>
<div className='my-2 bg-slate-200 dark:bg-slate-900 p-2 rounded cursor-pointer'>
<div
className='w-full flex justify-between items-center align-middle'
onClick={() => {