-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added dynamic icons to filters in tools page[Closes #1260] #1309
Open
bhat-shubham
wants to merge
14
commits into
json-schema-org:main
Choose a base branch
from
bhat-shubham:added_dynamic_icons_to_filter_in_tools_page
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+65
−10
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
723fe15
added dynamic icons to the filter in tools page
bhat-shubham 02ac24c
added dynamic icons to the filter in tools page
bhat-shubham 63d02df
added dynamic icons to the filter in tools page
bhat-shubham 8b5c652
added dynamic icons to the filter in tools page
bhat-shubham b41272d
added dynamic icons to the filter in tools page
bhat-shubham 8e903d7
to save before switching
bhat-shubham 3ff4de1
added proper icons to each filter on tools page
bhat-shubham 1a79e9c
Revert "added dynamic icons to the filter in tools page"
bhat-shubham 1641011
Revert "added dynamic icons to the filter in tools page"
bhat-shubham 7b8c534
Revert "to save before switching"
bhat-shubham 42f75f2
reverting changes
bhat-shubham 71bdeca
reverting the changes in sublodules
bhat-shubham bd07ca3
revert submodule changes
bhat-shubham c90a0a4
fixed prettier errors
bhat-shubham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,15 +26,15 @@ export default function DropdownMenu({ | |
}, [router]); | ||
|
||
return ( | ||
<div className='my-2 bg-slate-200 dark:bg-slate-900 p-2 rounded'> | ||
<div className='my-2 bg-slate-200 dark:bg-slate-900 p-2 rounded cursor-pointer'> | ||
<div | ||
className='w-full flex justify-between items-center align-middle' | ||
onClick={() => { | ||
setIsDropdownOpen((prev) => !prev); | ||
}} | ||
> | ||
{React.cloneElement(icon, { | ||
className: 'mr-2', | ||
className: 'mr-2 ml-2', | ||
})} | ||
<div className='text-slate-900 dark:text-slate-300 font-bold mr-auto'> | ||
{label} | ||
|
@@ -64,8 +64,11 @@ export default function DropdownMenu({ | |
<div | ||
className={classnames( | ||
'tools-dropdown-menu', | ||
'ml-0 mt-4 overflow-x-hidden overscroll-y-auto max-h-80', | ||
{ hidden: !isDropdownOpen }, | ||
'ml-0 mt-0 overflow-hidden transition-all duration-500 ease-in-out', | ||
{ | ||
'max-h-0 opacity-0 invisible': !isDropdownOpen, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Doesn't this make it more complicated? |
||
'max-h-80 overflow-y-auto opacity-100 visible': isDropdownOpen, | ||
}, | ||
)} | ||
> | ||
{children} | ||
|
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This object is redundant, it would better managed with
filters
object.