addressed requests #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codekansas
requested changes
Aug 2, 2024
environment.py
Outdated
| goal_path = Path(local_path) | ||
|
|
||
| if not (goal_path / repo_dir).exists(): | ||
| print(f"Cloning repository from {repo_url}") |
environment.py
Outdated
| ) | ||
| os.chdir(goal_path) | ||
| subprocess.run(["git", "sparse-checkout", "set", repo_dir], check=True) | ||
| print(f"Model files downloaded to {goal_path / repo_dir}") |
environment.py
Outdated
| subprocess.run(["git", "sparse-checkout", "set", repo_dir], check=True) | ||
| print(f"Model files downloaded to {goal_path / repo_dir}") | ||
| else: | ||
| print(f"Updating model files in {goal_path / repo_dir}") |
environment.py
Outdated
| os.chdir(goal_path) | ||
| subprocess.run(["git", "pull"], check=True) | ||
|
|
||
| print(f"Model files are up to date at {goal_path / repo_dir}") |
There was a problem hiding this comment.
LOL i changed it woops
There was a problem hiding this comment.
just didnt ocmmit
| path: str = os.path.join(os.path.dirname(__file__), "environments", "stompy", "legs.xml") | ||
| mj_model: mujoco.MjModel = mujoco.MjModel.from_xml_path(path) | ||
| # GitHub repository URL | ||
| repo_url = "https://github.com/nathanjzhao/mujoco-models.git" |
codekansas
requested changes
Aug 2, 2024
environment.py
Outdated
Comment on lines
26
to
28
| :param repo_url: URL of the GitHub repository | ||
| :param repo_dir: Directory within the repository containing the model files | ||
| :param local_path: Local path where files should be saved |
There was a problem hiding this comment.
Suggested change
| :param repo_url: URL of the GitHub repository | |
| :param repo_dir: Directory within the repository containing the model files | |
| :param local_path: Local path where files should be saved | |
| Args: | |
| repo_url: URL of the GitHub repository | |
| repo_dir: Directory within the repository containing the model files | |
| local_path: Local path where files should be saved |
codekansas
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.