Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve telemetry #4093

Merged
merged 9 commits into from
Jun 21, 2023
Merged

improve telemetry #4093

merged 9 commits into from
Jun 21, 2023

Conversation

devcatalin
Copy link
Member

This PR...

Changes

Fixes

How to test it

Screenshots

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

mortada-codes
mortada-codes previously approved these changes Jun 20, 2023
View reviewed changes
olensmar
olensmar requested changes Jun 20, 2023
View reviewed changes
src/components/organisms/CreateProjectModal/CreateProjectModal.tsx Outdated Show resolved Hide resolved
src/shared/models/telemetry.ts Outdated Show resolved Hide resolved
olensmar
olensmar previously approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@olensmar olensmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@devcatalin devcatalin changed the title fix: app_start/create_project event improve telemetry Jun 21, 2023
@devcatalin
Copy link
Member Author

devcatalin commented Jun 21, 2023 •
edited
Loading

Added the events for #4097 and #4096

This was linked to issues Jun 21, 2023
validation telemetry #4097
Closed
codeIntel telemetry #4096
Closed
@devcatalin
Copy link
Member Author

Also added telemetry for #4098

@devcatalin devcatalin linked an issue Jun 21, 2023 that may be closed by this pull request
telemetry on cluster type/runtime/k8s-version #4098
Closed
@devcatalin devcatalin requested a review from olensmar June 21, 2023 10:27
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jun 21, 2023
@devcatalin devcatalin requested a review from olensmar June 21, 2023 11:21
olensmar
olensmar previously approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@olensmar olensmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome - thank you!

@devcatalin devcatalin requested a review from olensmar June 21, 2023 11:28
@devcatalin devcatalin merged commit 34392c6 into main Jun 21, 2023
1 check passed
@devcatalin devcatalin deleted the devcatalin/refactor/missing-telemetry branch June 21, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olensmar olensmar olensmar approved these changes

@topliceanurazvan topliceanurazvan Awaiting requested review from topliceanurazvan topliceanurazvan is a code owner

@mortada-codes mortada-codes Awaiting requested review from mortada-codes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

telemetry on cluster type/runtime/k8s-version validation telemetry codeIntel telemetry
3 participants
@devcatalin @olensmar @mortada-codes