-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: WebUI NEO start page basic layout #2786
base: main
Are you sure you want to change the base?
Conversation
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
056411b
to
97917a8
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🔴 | Statements | 5.24% (+0.03% 🔼) |
395/7536 |
🔴 | Branches | 4.53% (-0.01% 🔻) |
237/5236 |
🔴 | Functions | 3.14% (+0.02% 🔼) |
78/2481 |
🔴 | Lines | 5.16% (+0.03% 🔼) |
380/7369 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
---|---|---|---|---|---|
🔴 | ... / ActionItemContent.tsx |
0% | 0% | 0% | 0% |
🔴 | pages/StartPage.tsx | 0% | 0% | 0% | 0% |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 8ba4b61
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The interactive type is selected when I click the Start Batch Session
button.
255afaa
to
d51430b
Compare
resolved! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improved en-US and ko-KR description of each feature / button which shown in UI.
Some typos in ko-KR is also fixed.
For en-US, we will limit the use of 'a / the' on title to make is concise.
For ko-KR, we will limit the use of '~하기' in overall cases.
d51430b
to
f9dd0c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed that my changes have been reflected. LGTM.
f9dd0c5
to
e2f4644
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
e2f4644
to
752f0d5
Compare
There is draft PR which I created, please check it. |
60b7a2f
to
53bdf55
Compare
53bdf55
to
ef57508
Compare
I tested it on pnpm patch PR and found it works fine, so I modified it to work based on pnpm patch. I've also fixed the scroll position issue. @yomybaby |
ef57508
to
368ca41
Compare
f4d19c9
to
44ef647
Compare
44ef647
to
844bc22
Compare
92e62ca
to
99960b4
Compare
844bc22
to
7d362f8
Compare
99960b4
to
e520a53
Compare
7d362f8
to
0822b3b
Compare
e520a53
to
8a83be2
Compare
8a83be2
to
31109fe
Compare
31109fe
to
9cf442d
Compare
9cf442d
to
22d27de
Compare
22d27de
to
8ba4b61
Compare
This PR is about UI changing for
Backend.AI WebUI NEO
#2835Changes:
ActionItemContent
component (can be used as primary action card for start page and subsequent pages)How to test:
Checklist: (if applicable)