Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: WebUILink and WebUINavigate component #2846

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

yomybaby
Copy link
Member

@yomybaby yomybaby commented Nov 13, 2024

Resolves #2198

Introduces WebUILink and WebUINavigate components to handle navigation events consistently across the application. These components dispatch custom events for routing in Web component world when navigation occurs, ensuring proper synchronization between React routing and external navigation handlers.

The routing configuration has been restructured to use nested routes, particularly for the session and serving sections, improving route organization and maintainability.

Copy link

graphite-app bot commented Nov 13, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the size:L 100~500 LoC label Nov 13, 2024
Copy link
Member Author

yomybaby commented Nov 13, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@yomybaby yomybaby requested a review from ironAiken2 November 13, 2024 07:34
@yomybaby yomybaby marked this pull request as ready for review November 13, 2024 07:34
@yomybaby yomybaby linked an issue Nov 13, 2024 that may be closed by this pull request
@yomybaby yomybaby force-pushed the featue/mainlayout-neo-header branch from d92c1ea to 8af56f0 Compare November 14, 2024 01:15
@yomybaby yomybaby force-pushed the feature/webui-link-and-navigate-component branch from fc6f867 to 9169a62 Compare November 14, 2024 01:15
Copy link
Contributor

@ironAiken2 ironAiken2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yomybaby yomybaby force-pushed the featue/mainlayout-neo-header branch from 8af56f0 to 13b62c1 Compare November 15, 2024 03:36
@yomybaby yomybaby force-pushed the feature/webui-link-and-navigate-component branch from 9169a62 to b5ce6fd Compare November 15, 2024 03:36
@yomybaby yomybaby force-pushed the featue/mainlayout-neo-header branch from 13b62c1 to 7616df6 Compare November 15, 2024 07:38
@yomybaby yomybaby force-pushed the feature/webui-link-and-navigate-component branch from b5ce6fd to f13e145 Compare November 15, 2024 07:38
@yomybaby yomybaby force-pushed the featue/mainlayout-neo-header branch from 7616df6 to 076dd76 Compare November 16, 2024 03:00
@yomybaby yomybaby force-pushed the feature/webui-link-and-navigate-component branch from f13e145 to 3b1b867 Compare November 16, 2024 03:00
@yomybaby yomybaby force-pushed the featue/mainlayout-neo-header branch from 076dd76 to ad3ab01 Compare November 16, 2024 03:29
@yomybaby yomybaby force-pushed the feature/webui-link-and-navigate-component branch from 3b1b867 to 80fccdc Compare November 16, 2024 03:29
@yomybaby yomybaby force-pushed the featue/mainlayout-neo-header branch from ad3ab01 to 6a40a93 Compare November 17, 2024 00:19
@yomybaby yomybaby force-pushed the feature/webui-link-and-navigate-component branch from 80fccdc to 4b2abdc Compare November 17, 2024 00:19
@ironAiken2 ironAiken2 force-pushed the feature/webui-link-and-navigate-component branch from 4b2abdc to 62d34f9 Compare November 18, 2024 05:28
@yomybaby yomybaby force-pushed the featue/mainlayout-neo-header branch from 6a40a93 to 9fc59ae Compare November 19, 2024 09:39
@yomybaby yomybaby force-pushed the feature/webui-link-and-navigate-component branch from 4b2abdc to d89a170 Compare November 19, 2024 09:39
@yomybaby yomybaby force-pushed the featue/mainlayout-neo-header branch from 9fc59ae to 2148a93 Compare November 20, 2024 06:52
@yomybaby yomybaby force-pushed the feature/webui-link-and-navigate-component branch from d89a170 to 39796fa Compare November 20, 2024 06:53
Copy link

graphite-app bot commented Nov 20, 2024

Merge activity

Resolves #2198

Introduces `WebUILink` and `WebUINavigate` components to handle navigation events consistently across the application. These components dispatch custom events for routing in Web component world when navigation occurs, ensuring proper synchronization between React routing and external navigation handlers.

The routing configuration has been restructured to use nested routes, particularly for the session and serving sections, improving route organization and maintainability.
@yomybaby yomybaby force-pushed the featue/mainlayout-neo-header branch from 2148a93 to f3ac7fa Compare November 20, 2024 06:55
@yomybaby yomybaby force-pushed the feature/webui-link-and-navigate-component branch from 39796fa to aa466b1 Compare November 20, 2024 06:56
Base automatically changed from featue/mainlayout-neo-header to main November 20, 2024 07:00
@graphite-app graphite-app bot merged commit aa466b1 into main Nov 20, 2024
4 checks passed
@graphite-app graphite-app bot deleted the feature/webui-link-and-navigate-component branch November 20, 2024 07:01
@yomybaby yomybaby mentioned this pull request Nov 26, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L 100~500 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: WebUILinkTo
2 participants