feat: NEO sider's toggle button and refactoring #2853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This was referenced Nov 15, 2024
yomybaby
force-pushed
the
feature/webui-neo-toggle-sider
branch
2 times, most recently
from
b2825e2 to
f7c1327
Compare
yomybaby
force-pushed
the
feature/neo-sider
branch
from
aecdb0d to
29048ea
Compare
yomybaby
force-pushed
the
feature/webui-neo-toggle-sider
branch
2 times, most recently
from
9f465cc to
e79c472
Compare
yomybaby
force-pushed
the
feature/neo-sider
branch
from
29048ea to
55a302a
Compare
yomybaby
force-pushed
the
feature/webui-neo-toggle-sider
branch
from
e79c472 to
e4c88ef
Compare
yomybaby
force-pushed
the
feature/neo-sider
branch
from
55a302a to
d3161de
Compare
yomybaby
force-pushed
the
feature/webui-neo-toggle-sider
branch
from
e4c88ef to
7f136aa
Compare
yomybaby
force-pushed
the
feature/neo-sider
branch
from
d3161de to
1b30a97
Compare
yomybaby
force-pushed
the
feature/webui-neo-toggle-sider
branch
from
7f136aa to
eb4ea48
Compare
yomybaby
force-pushed
the
feature/neo-sider
branch
from
1b30a97 to
bc775b7
Compare
yomybaby
force-pushed
the
feature/webui-neo-toggle-sider
branch
3 times, most recently
from
930d3ba to
236b757
Compare
yomybaby
force-pushed
the
feature/neo-sider
branch
from
bc775b7 to
e65dfe4
Compare
yomybaby
force-pushed
the
feature/webui-neo-toggle-sider
branch
3 times, most recently
from
5423dc8 to
8e397a2
Compare
Closed
ironAiken2
force-pushed
the
feature/neo-sider
branch
from
e65dfe4 to
a436278
Compare
ironAiken2
force-pushed
the
feature/webui-neo-toggle-sider
branch
from
8e397a2 to
e7e9878
Compare
This was referenced Nov 18, 2024
yomybaby
force-pushed
the
feature/neo-sider
branch
from
a436278 to
af6f180
Compare
yomybaby
force-pushed
the
feature/webui-neo-toggle-sider
branch
from
e7e9878 to
07b7970
Compare
yomybaby
force-pushed
the
feature/neo-sider
branch
from
af6f180 to
3c30dc1
Compare
yomybaby
force-pushed
the
feature/webui-neo-toggle-sider
branch
from
07b7970 to
4541f88
Compare
Merge activity
|
 **Changes:** - Added keyboard shortcut '[' to toggle sidebar collapse state - Introduced a collapsible button on the sidebar that appears on hover - Moved sidebar footer content into a more structured layout - Added `useKeyboardShortcut` hook to handle keyboard shortcuts when no input is focused - Refactored BAISider component to use forwardRef and improve layout structure - Standardized sidebar width constants (COLLAPSED_SIDER_WIDTH = 74, SIDER_WIDTH = 240) - Removed bottomText prop from BAISider in favor of direct content rendering - Added hover detection for showing/hiding the collapse toggle button **Testing Requirements:** 1. Verify the '[' keyboard shortcut toggles sidebar when no input is focused 2. Check that the collapse button appears on sidebar hover 3. Confirm sidebar footer content displays correctly in both expanded/collapsed states 4. Test that keyboard shortcuts don't trigger when inputs or modals are focused
yomybaby
force-pushed
the
feature/neo-sider
branch
from
3c30dc1 to
800f145
Compare
yomybaby
force-pushed
the
feature/webui-neo-toggle-sider
branch
from
4541f88 to
33f7fba
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
useKeyboardShortcuthook to handle keyboard shortcuts when no input is focusedTesting Requirements: