Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement ID based client workflow to ContainerRegistry graphql API #2615

Conversation

jopemachine
Copy link
Member

@jopemachine jopemachine commented Aug 2, 2024

Overview

  • The existing ContainerRegistry graphql API based on hostname will continue to be maintained for compatibility, but it will be deprecated due to breaking changes.

  • The new ContainerRegistry API has been renamed to ContainerRegistryNode and features an updated client workflow based on ID instead of hostname. Please refer to the test code for usage instructions.

  • hostname is changed into registry_name.


Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Update of end-to-end CLI integration tests in ai.backend.test
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation

📚 Documentation preview 📚: https://sorna--2615.org.readthedocs.build/en/2615/


📚 Documentation preview 📚: https://sorna-ko--2615.org.readthedocs.build/ko/2615/

@github-actions github-actions bot added area:docs Documentations comp:manager Related to Manager component size:XL 500~ LoC labels Aug 2, 2024
@jopemachine jopemachine closed this Aug 2, 2024
@jopemachine jopemachine force-pushed the topic/08-02-feat_implement_id-based_client_workflow_to_containerregistry_api branch from 1ae93d1 to 0529d8f Compare August 2, 2024 12:00
@jopemachine jopemachine reopened this Aug 2, 2024
@jopemachine jopemachine marked this pull request as ready for review August 2, 2024 12:08
@jopemachine jopemachine added this to the 24.09 milestone Aug 3, 2024
@jopemachine jopemachine force-pushed the feat/migration-container-registries branch from 0529d8f to a27f32f Compare August 3, 2024 02:11
@jopemachine jopemachine force-pushed the topic/08-02-feat_implement_id-based_client_workflow_to_containerregistry_api branch from 63dc857 to e1af726 Compare August 3, 2024 02:11
@jopemachine jopemachine force-pushed the topic/08-02-feat_implement_id-based_client_workflow_to_containerregistry_api branch from e1af726 to 18bd46c Compare August 3, 2024 05:23
@fregataa fregataa force-pushed the topic/08-02-feat_implement_id-based_client_workflow_to_containerregistry_api branch from 18bd46c to 67f466e Compare August 3, 2024 08:24
@fregataa fregataa force-pushed the feat/migration-container-registries branch from 956f205 to 0fe95df Compare August 4, 2024 02:05
@fregataa fregataa force-pushed the topic/08-02-feat_implement_id-based_client_workflow_to_containerregistry_api branch 3 times, most recently from 9213281 to fe6820e Compare August 4, 2024 02:45
@jopemachine jopemachine force-pushed the feat/migration-container-registries branch from 0fe95df to 5281c33 Compare August 5, 2024 06:20
@jopemachine jopemachine force-pushed the topic/08-02-feat_implement_id-based_client_workflow_to_containerregistry_api branch from 88562c8 to 6a1908e Compare August 5, 2024 06:20
@jopemachine jopemachine force-pushed the feat/migration-container-registries branch from 5281c33 to c1445da Compare August 5, 2024 09:03
@jopemachine jopemachine force-pushed the topic/08-02-feat_implement_id-based_client_workflow_to_containerregistry_api branch 3 times, most recently from c23d3c3 to edfc821 Compare August 6, 2024 01:58
@jopemachine jopemachine force-pushed the topic/08-13-feat_add_project_column_to_the_images_table_and_refactoring_imageref_logic branch from fa39d8d to b48fa28 Compare September 30, 2024 14:36
@jopemachine jopemachine force-pushed the topic/08-02-feat_implement_id-based_client_workflow_to_containerregistry_api branch from 80c0f6d to 3f749a8 Compare September 30, 2024 14:36
@jopemachine jopemachine modified the milestones: 24.03, 24.09 Sep 30, 2024
Base automatically changed from topic/08-13-feat_add_project_column_to_the_images_table_and_refactoring_imageref_logic to main September 30, 2024 14:55
@kyujin-cho kyujin-cho added this pull request to the merge queue Sep 30, 2024
Merged via the queue into main with commit 7f968e7 Sep 30, 2024
21 of 22 checks passed
@kyujin-cho kyujin-cho deleted the topic/08-02-feat_implement_id-based_client_workflow_to_containerregistry_api branch September 30, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:docs Documentations comp:manager Related to Manager component size:XL 500~ LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants