-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support GitHub Container Registry based on PostgreSQL
#2621
Merged
kyujin-cho
merged 6 commits into
main
from
topic/08-03-feat_support_github_container_registry_based_on_psq
Sep 30, 2024
Merged
feat: Support GitHub Container Registry based on PostgreSQL
#2621
kyujin-cho
merged 6 commits into
main
from
topic/08-03-feat_support_github_container_registry_based_on_psq
Sep 30, 2024
+78
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 3, 2024
1 task
PostgreSQL
36de125
to
8c4d8c0
Compare
ec64f48
to
1cd3649
Compare
This was referenced Aug 3, 2024
68c9931
to
429d3f8
Compare
2cc4731
to
ffc02b0
Compare
429d3f8
to
8cfc934
Compare
f983fcc
to
3de822b
Compare
8cfc934
to
c1e19f3
Compare
3de822b
to
80babfd
Compare
c1e19f3
to
1003434
Compare
80babfd
to
6ad5518
Compare
1003434
to
0bbb489
Compare
6ad5518
to
d64bf7f
Compare
0bbb489
to
cf21f01
Compare
d64bf7f
to
f9848eb
Compare
f42a5db
to
8eaba4c
Compare
11a5742
to
338075a
Compare
8eaba4c
to
1e39787
Compare
338075a
to
61cc5d5
Compare
1e39787
to
40922c3
Compare
61cc5d5
to
8605540
Compare
40922c3
to
bc78e16
Compare
8605540
to
0396238
Compare
bc78e16
to
e3f3c66
Compare
0396238
to
da53902
Compare
e3f3c66
to
27d8b1b
Compare
da53902
to
cef7cba
Compare
27d8b1b
to
3794db3
Compare
cef7cba
to
14f29f8
Compare
3794db3
to
13bbbc3
Compare
14f29f8
to
461845b
Compare
13bbbc3
to
ab9a9f7
Compare
Base automatically changed from
topic/09-06-feat_support_legacy_docker_image_manifest
to
main
September 30, 2024 15:11
461845b
to
beb4b76
Compare
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp:manager
Related to Manager component
require:db-migration
Automatically set when alembic migrations are added or updated
size:M
30~100 LoC
type:feature
Add new features
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fix #2337.
Test
Manually tested it using the following methods.
In this PR, the
cr.backend.ai/stable/python:3.9-ubuntu20.04
image is used as a placeholder for testing.Prerequisite
cr.backend.ai/stable/python
image to your GitHub package for testing.Note
The
entity_type
should be either "users" or "orgs".container_registry
column of thegroups
table.ghcr.io
value toallowed_docker_registries
column ofdomains
table using below commandTest scenarios
Verify that the container registry added in this PR is functioning based on several scenarios.
If there are additional scenarios that need testing, please leave a comment.
1. Image Rescan
Image rescanning should work through the following command.
2. Create a session from the pulled image
Run a session using the downloaded image.
3. Commit the changes and push it to the container registry.
Commit the changes using the
convert-to-image
command and push them to the container registry.Checklist: (if applicable)