refactor: Base ContainerRegistry's scan_tag and implement MEDIA_TYPE_DOCKER_MANIFEST type handling
#2620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
comp:manager
jopemachine
force-pushed
the
topic/08-02-feat_implement_id-based_client_workflow_to_containerregistry_api
branch
from
63dc857
to
e1af726
Compare
jopemachine
force-pushed
the
topic/08-03-refactor_base_containerregistry_s_scan_tag_and_implement_media_type_docker_manifest_type_handling
branch
from
36de125
to
8c4d8c0
Compare
This was referenced Aug 3, 2024
jopemachine
force-pushed
the
topic/08-02-feat_implement_id-based_client_workflow_to_containerregistry_api
branch
from
e1af726
to
18bd46c
Compare
jopemachine
force-pushed
the
topic/08-03-refactor_base_containerregistry_s_scan_tag_and_implement_media_type_docker_manifest_type_handling
branch
from
68c9931
to
429d3f8
Compare
jopemachine
added
type:refactor
fregataa
force-pushed
the
topic/08-02-feat_implement_id-based_client_workflow_to_containerregistry_api
branch
4 times, most recently
from
9213281
to
fe6820e
Compare
jopemachine
force-pushed
the
topic/08-02-feat_implement_id-based_client_workflow_to_containerregistry_api
branch
from
88562c8
to
6a1908e
Compare
jopemachine
force-pushed
the
topic/08-03-refactor_base_containerregistry_s_scan_tag_and_implement_media_type_docker_manifest_type_handling
branch
from
429d3f8
to
8cfc934
Compare
jopemachine
force-pushed
the
topic/08-02-feat_implement_id-based_client_workflow_to_containerregistry_api
branch
from
6a1908e
to
6688f0c
Compare
jopemachine
force-pushed
the
topic/08-03-refactor_base_containerregistry_s_scan_tag_and_implement_media_type_docker_manifest_type_handling
branch
from
8cfc934
to
c1e19f3
Compare
jopemachine
force-pushed
the
topic/08-02-feat_implement_id-based_client_workflow_to_containerregistry_api
branch
from
6688f0c
to
c23d3c3
Compare
jopemachine
force-pushed
the
topic/08-03-refactor_base_containerregistry_s_scan_tag_and_implement_media_type_docker_manifest_type_handling
branch
from
c1e19f3
to
1003434
Compare
jopemachine
force-pushed
the
topic/08-02-feat_implement_id-based_client_workflow_to_containerregistry_api
branch
from
c23d3c3
to
edfc821
Compare
jopemachine
force-pushed
the
topic/08-03-refactor_base_containerregistry_s_scan_tag_and_implement_media_type_docker_manifest_type_handling
branch
from
1003434
to
0bbb489
Compare
…PE_DOCKER_MANIFEST` type handling
jopemachine
force-pushed
the
topic/08-02-feat_implement_id-based_client_workflow_to_containerregistry_api
branch
from
80c0f6d
to
3f749a8
Compare
jopemachine
force-pushed
the
topic/08-03-refactor_base_containerregistry_s_scan_tag_and_implement_media_type_docker_manifest_type_handling
branch
from
5a7b249
to
0d22e40
Compare
Base automatically changed from
topic/08-02-feat_implement_id-based_client_workflow_to_containerregistry_api
to
main
September 30, 2024 15:00
kyujin-cho
deleted the
topic/08-03-refactor_base_containerregistry_s_scan_tag_and_implement_media_type_docker_manifest_type_handling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
base.py's_scan_tagupdate for handlingMEDIA_TYPE_DOCKER_MANIFESTIn the existing code, only
MEDIA_TYPE_DOCKER_MANIFEST_LISTandMEDIA_TYPE_OCI_INDEXtypes were handled in_scan_tag, so a runtime error occurred whenMEDIA_TYPE_DOCKER_MANIFESTtype was passed ascontent_type.However, in
harbor.py, handling based onmanifest_media_typeis processed by separate functions such as_process_oci_indexand_process_docker_v2_multiplatform_image, so handling forMEDIA_TYPE_DOCKER_MANIFESThas been added by extracting these functions with the same signatures.Adding handling for the
MEDIA_TYPE_DOCKER_MANIFESTtype (_process_docker_v2_image) seems not to be specific only to ghcr, so it was added tobase.py.Checklist: (if applicable)