Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(BooleanSubalgebra): closure of supClosed+infClosed set containing bot+top #20251

Closed
wants to merge 2 commits into from

Conversation

alreadydone
Copy link
Contributor

@alreadydone alreadydone commented Dec 26, 2024

Every element in the closure of such a set s can be written as a finite sup of elements of the form a \ b with a, b in s.


Open in Gitpod

@alreadydone alreadydone added t-algebra Algebra (groups, rings, fields, etc) t-order Order theory labels Dec 26, 2024
Copy link

github-actions bot commented Dec 26, 2024

PR summary cccb6fe160

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ closure_sdiff_sup_induction
+ mem_closure_iff_sup_sdiff

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for sorting this out!

Mathlib/Order/BooleanSubalgebra.lean Outdated Show resolved Hide resolved
Mathlib/Order/BooleanSubalgebra.lean Outdated Show resolved Hide resolved
Mathlib/Order/BooleanSubalgebra.lean Outdated Show resolved Hide resolved
@alreadydone alreadydone changed the title feat(BooleanSubalgebra): closure of infClosed+supClosed set containing bot+top feat(BooleanSubalgebra): closure of latticeClosed set containing bot+top Dec 26, 2024
@alreadydone alreadydone changed the title feat(BooleanSubalgebra): closure of latticeClosed set containing bot+top feat(BooleanSubalgebra): closure of supClosed+infClosed set containing bot+top Dec 26, 2024
@Ruben-VandeVelde Ruben-VandeVelde added the awaiting-author A reviewer has asked the author a question or requested changes label Dec 26, 2024
@alreadydone alreadydone force-pushed the mem_closure_iff_sup_sdiff branch from 9d36f9f to cccb6fe Compare December 26, 2024 12:07
@alreadydone alreadydone removed the awaiting-author A reviewer has asked the author a question or requested changes label Dec 26, 2024
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also have the dual versions using himp?

@alreadydone
Copy link
Contributor Author

Can we also have the dual versions using himp?

Is it useful? closure_bot_sup_induction didn't have a top_inf counterpart. Maybe you can try to use the dual Boolean algebra to prove it?

@alreadydone alreadydone force-pushed the mem_closure_iff_sup_sdiff branch from 2a50c59 to cccb6fe Compare December 26, 2024 12:50
@YaelDillies
Copy link
Collaborator

maintainer merge

Thanks!

Copy link

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Jan 2, 2025
mathlib-bors bot pushed a commit that referenced this pull request Jan 2, 2025
…g bot+top (#20251)

Every element in the closure of such a set `s` can be written as a finite sup of elements of the form `a \ b` with `a`, `b` in `s`.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 2, 2025

Pull request successfully merged into master.

Build succeeded!

And happy new year! 🎉

@mathlib-bors mathlib-bors bot changed the title feat(BooleanSubalgebra): closure of supClosed+infClosed set containing bot+top [Merged by Bors] - feat(BooleanSubalgebra): closure of supClosed+infClosed set containing bot+top Jan 2, 2025
@mathlib-bors mathlib-bors bot closed this Jan 2, 2025
@mathlib-bors mathlib-bors bot deleted the mem_closure_iff_sup_sdiff branch January 2, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc) t-order Order theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants