Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log improve #1097

Closed
wants to merge 7 commits into from
Closed

log improve #1097

wants to merge 7 commits into from

Conversation

corneliusroemer
Copy link
Contributor

@corneliusroemer corneliusroemer commented Feb 23, 2024 •
edited
Loading

resolves #

preview URL: https://log-improve.loculus.org

Summary

Screenshot

PR Checklist

  • All necessary documentation has been adapted.
  • The implemented feature is covered by an appropriate test.

@corneliusroemer corneliusroemer added the preview Triggers a deployment to argocd label Feb 23, 2024
theosanderson
theosanderson reviewed Feb 23, 2024
View reviewed changes
website/src/middleware/authMiddleware.ts Outdated
export function setCookie(context: APIContext, token: TokenCookie) {
deleteCookie(context);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This really shouldn't have any effect, fwiw

@corneliusroemer corneliusroemer mentioned this pull request Feb 23, 2024
Closed
@corneliusroemer
Copy link
Contributor Author

Meh, not getting anywhere again, giving up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theosanderson theosanderson theosanderson left review comments

Assignees
No one assigned
Labels
preview Triggers a deployment to argocd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corneliusroemer @theosanderson