Improve bridge command parser #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: LucasHaug <[email protected]>
Signed-off-by: LucasHaug <[email protected]>
Signed-off-by: LucasHaug <[email protected]>
Signed-off-by: LucasHaug <[email protected]>
Signed-off-by: LucasHaug <[email protected]>
Signed-off-by: LucasHaug <[email protected]>
Signed-off-by: LucasHaug <[email protected]>
Signed-off-by: LucasHaug <[email protected]>
Signed-off-by: LucasHaug <[email protected]>
Signed-off-by: LucasHaug <[email protected]>
Signed-off-by: LucasHaug <[email protected]>
Signed-off-by: LucasHaug <[email protected]>
Signed-off-by: LucasHaug <[email protected]>
Signed-off-by: LucasHaug <[email protected]>
Signed-off-by: LucasHaug <[email protected]>
Signed-off-by: LucasHaug <[email protected]>
Signed-off-by: LucasHaug <[email protected]>
Signed-off-by: LucasHaug <[email protected]>
Signed-off-by: LucasHaug <[email protected]>
Signed-off-by: LucasHaug <[email protected]>
Signed-off-by: LucasHaug <[email protected]>
Signed-off-by: LucasHaug <[email protected]>
jwallace42
approved these changes
Apr 6, 2023
|
Any updates on this? |
|
After we run with this for a bit, should report upstream that it's mergeable |
paulbovbel
added a commit
that referenced
this pull request
May 2, 2023
* Refactor command parser to use vector of char* Signed-off-by: LucasHaug <[email protected]> * Add argc argv splitter to dynamic bridge Signed-off-by: LucasHaug <[email protected]> * Add argc argv splitter to paramter bridge Signed-off-by: LucasHaug <[email protected]> * Update github action Signed-off-by: LucasHaug <[email protected]> * Fix parameter bridge argv split Signed-off-by: LucasHaug <[email protected]> * Remove static argv reading Signed-off-by: LucasHaug <[email protected]> * Add command parser to parameter bridge Signed-off-by: LucasHaug <[email protected]> * Fix compilation errors Signed-off-by: LucasHaug <[email protected]> * Fix compilation errors Signed-off-by: LucasHaug <[email protected]> * Fix parameter bidge command parser Signed-off-by: LucasHaug <[email protected]> * Refactor to add command parser utils file Signed-off-by: LucasHaug <[email protected]> * Add github action issue workaround Signed-off-by: LucasHaug <[email protected]> * Ty to run github action inside container Signed-off-by: LucasHaug <[email protected]> * Fix ROS2 args when no ROS1 args Signed-off-by: LucasHaug <[email protected]> * ⏪ Revert changes on GitHub Action config Signed-off-by: LucasHaug <[email protected]> * Change parameter bridge ROS init order Signed-off-by: LucasHaug <[email protected]> * Rename parser functions Signed-off-by: LucasHaug <[email protected]> * Add get_option_values function Signed-off-by: LucasHaug <[email protected]> * Fix wrong help for the parameter bridge Signed-off-by: LucasHaug <[email protected]> * Fix get_option_values parser function Signed-off-by: LucasHaug <[email protected]> * Refactor bridges to use the get_option_values Signed-off-by: LucasHaug <[email protected]> * Add running scetion to README Signed-off-by: LucasHaug <[email protected]> * Add print pairs to parameter bridge --------- Signed-off-by: LucasHaug <[email protected]> Co-authored-by: LucasHaug <[email protected]>
That would be great I think, maybe it helps make the review process faster. Besides, just to let you know, I realized that I mistakenly commented some error messages, nothing critical. I reverted the change in this commit here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From ros2#396 upstream