Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed to use resource_bundle instead of resource #4525

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

Francisco-Costa98
Copy link
Contributor

@Francisco-Costa98 Francisco-Costa98 commented Aug 7, 2023

Description

solves issue #4516
changed to use the non-deprecated resource_bundle in the podspec file instead of resources -> this fixes the multiple output commands produce Assets.Car error since the release of xcode 12

  • created a previous PR in the past but need to merge from main - so created a new PR

---------- CHECKLIST ----------

  1. Add related labels (bug, feature, new API(s), SEMVER-MAJOR, needs-backporting, etc.).
  2. Update progress status on the project board.
  3. Request a review from the team, if not a draft.
  4. Add targeted milestone, when applicable.
  5. Create ticket tracking addition of public documentation pages entry, when applicable.
  6. Update Changelog.
  7. Rebase onto main from the branch before merge.
    -->

@santitopo
Copy link

Hey @Francisco-Costa98! Really interested on this! What's the current status?

This fix would enable React Native Expo projects to use the module as well! Thx for that!

👉 #4553

@Udumft Udumft merged commit e0cf0f6 into mapbox:main Sep 29, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants