Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh-cn] Update 'block formatting context' #14023

Merged
merged 4 commits into from
Jul 4, 2023
Merged

[zh-cn] Update 'block formatting context' #14023

merged 4 commits into from
Jul 4, 2023

Conversation

jasonren0403
Copy link
Contributor

Description

start revamping block- and inline- glossary

Motivation

Additional details

Related issues and pull requests

Part of #12632

@jasonren0403 jasonren0403 requested a review from a team as a code owner July 3, 2023 15:48
@jasonren0403 jasonren0403 requested review from irvin and removed request for a team July 3, 2023 15:48
@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label Jul 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023 •
edited
Loading

Preview URLs

Flaws (2)

URL: /zh-CN/docs/Web/Guide/CSS/Block_formatting_context
Title: 区块格式化上下文
Flaw count: 2

  • macros:
    • /zh-CN/docs/Web/CSS/column-width does not exist but fell back to /en-US/docs/Web/CSS/column-width
  • translation_differences:
    • Differences in the important macros (2 in common of 10 possible)
External URLs (2)

URL: /zh-CN/docs/Web/Guide/CSS/Block_formatting_context
Title: 区块格式化上下文

(comment last updated: 2023-07-04 14:36:13)

yin1999
yin1999 approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just two suggestions

files/zh-cn/web/guide/css/block_formatting_context/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/guide/css/block_formatting_context/index.md Outdated Show resolved Hide resolved
@jasonren0403 jasonren0403 requested a review from yin1999 July 4, 2023 14:34
@jasonren0403 jasonren0403 mentioned this pull request Jul 4, 2023
Open
@yin1999 yin1999 merged commit 60d3072 into main Jul 4, 2023
8 checks passed
@yin1999 yin1999 deleted the bfc-revise-zhcn branch July 4, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irvin irvin Awaiting requested review from irvin irvin is a code owner automatically assigned from mdn/yari-content-zh

@yin1999 yin1999 Awaiting requested review from yin1999

Assignees
No one assigned
Labels
l10n-zh Issues related to Chinese content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonren0403 @yin1999