-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): Reuse markdownlint config files for 'files' and 'docs' hiera… #15106
Conversation
@queengooborg we can go with this as this is what you were trying to implement. |
Preview URLs Flaws (30)URL:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirming this works as intended.
I see there's a Prettier formatting performed as well, but this was probably performed during the merge commit.
Thanks @OnkarRuikar and @queengooborg! |
Addresses #14246 (comment)
The config under
files/zh-cn/
directory can be reused indocs/zh-cn/
using the changes in the PR. Same forzh-tw
locale.Explanation
The config file
.markdownlint.jsonc
is related to the coremarkdownlint
library. And.markdownlint-cli2.jsonc
is related tomarkdownlint-cli2
tool that uses the markdownlint.The
extends
property belongs to theconfig
property in.markdownlint-cli2.jsonc
. Under the hood theconfig
property is the configuration for.markdownlint.jsonc
. As theconfig
is solely related tomakrdownlint
theextends
need to point to.markdownlint.jsonc
files not.markdownlint-cli2.jsonc
.Note
.markdownlint-cli2.jsonc
is used only at the root level to provide CLI specific configs. And all core markdownlint related configurations have been put in.markdownlint.jsonc
files.