Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations update from Hosted Weblate #2233

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

weblate
Copy link
Contributor

@weblate weblate commented Nov 1, 2024

Translations update from Hosted Weblate for LosslessCut/LosslessCut.

Current translation status:

Weblate translation status

Summary by CodeRabbit

  • New Features

    • Added new translations in Spanish, Russian, Chinese, Czech, Italian, Japanese, German, Polish, and Slovak for important user messages regarding file export limitations and operational recommendations, including warnings about file name length and simultaneous adjustments to output FPS.
    • Introduced an empty JSON object for future translations in Tamil.
  • Bug Fixes

    • Improved clarity in existing translations with updated punctuation for "Examples."
  • Documentation

    • Enhanced user guidance and error handling related to file operations through updated translations.

@weblate weblate force-pushed the weblate-losslesscut-losslesscut branch from fcce9c4 to 361996a Compare November 1, 2024 11:18
Copy link

coderabbitai bot commented Nov 1, 2024

Walkthrough

The changes in this pull request involve updates to the translation files for Spanish, Russian, Chinese, Czech, Italian, Japanese, Slovak, German, Tamil, and Polish. Each language file has received new translation entries addressing user messages about file export limitations, output FPS adjustments, and fallback file naming. Additionally, minor adjustments were made to existing translations for clarity and punctuation. A new empty translation file for Tamil has also been created, and the Polish translations have been significantly expanded to enhance user guidance and error handling.

Changes

File Path Change Summary
locales/es/translation.json - Added translations: "File name is too long and cannot be exported."
- Added translations: "Adjusting the output FPS and cutting at the same time will cause incorrect cuts. Consider instead doing it in two separate steps."
- Added translations: "Fell back to default output file name."
- Updated translation for "Examples": "Ejemplos" → "Ejemplos," (added comma)
locales/ru/translation.json - Added translations: "File name is too long and cannot be exported."
- Added translations: "Adjusting the output FPS and cutting at the same time will cause incorrect cuts. Consider instead doing it in two separate steps."
- Added translations: "Fell back to default output file name."
- Updated phrasing for metadata preservation description.
locales/zh_Hans/translation.json - Added translations: "File name is too long and cannot be exported."
- Added translations: "Adjusting the output FPS and cutting at the same time will cause incorrect cuts. Consider instead doing it in two separate steps."
- Added translations: "Fell back to default output file name."
- Minor adjustment to existing translation for customizing merged file name.
locales/cs/translation.json - Added translations: "File name is too long and cannot be exported."
- Added translations: "Adjusting the output FPS and cutting at the same time will cause incorrect cuts. Consider instead doing it in two separate steps."
- Added translations: "Fell back to default output file name."
- Updated translation for "Merge cuts": "Spojit sřihy" → "Spojit segmenty"
locales/it/translation.json - Added translations: "File name is too long and cannot be exported."
- Added translations: "Fell back to default output file name."
- Added translations: "Adjusting the output FPS and cutting at the same time will cause incorrect cuts. Consider instead doing it in two separate steps."
locales/ja/translation.json - Added translations: "You are not allowed to write the output file..."
- Added translations: "Fell back to default output file name."
- Added translations: "File name is too long and cannot be exported."
- Added translations: "Adjusting the output FPS and cutting at the same time will cause incorrect cuts. Consider instead doing it in two separate steps."
locales/sk/translation.json - Added translations: "File name is too long and cannot be exported."
- Added translations: "Adjusting the output FPS and cutting at the same time will cause incorrect cuts. Consider instead doing it in two separate steps."
- Added translations: "Fell back to default output file name."
locales/de/translation.json - Added translations: "Adjusting the output FPS and cutting at the same time will cause incorrect cuts. Consider instead doing it in two separate steps."
- Added translations: "File name is too long and cannot be exported."
- Added translations: "Fell back to default output file name."
locales/ta/translation.json - New file created: locales/ta/translation.json with an empty JSON object {}.
locales/pl/translation.json - Added multiple new entries related to file handling, user guidance, and error messages.

Possibly related PRs

  • Translations update from Hosted Weblate #2010: The changes in the main PR are related to the retrieved PR as both include updates to translation files that address similar warnings and messages regarding file name length and operational advice related to adjusting output FPS during cuts.
  • Translations update from Hosted Weblate #2119: The changes in the main PR and the retrieved PR are related as both introduce new translation entries that include warnings about file name length and issues with adjusting output FPS while cutting, specifically in the locales/ru/translation.json file.
  • Translations update from Hosted Weblate #2185: The changes in the main PR and the retrieved PR are related as both include updates to the Spanish translations in the locales/es/translation.json file, specifically adding similar new translation entries regarding file name length limitations and warnings about adjusting FPS during cuts.

🐇 In the land of code, where translations play,
New words were added to brighten the day.
For long file names, a warning we share,
Adjusting FPS? Do it with care!
With commas in place, our messages flow,
Helping users as they learn and grow! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@weblate weblate force-pushed the weblate-losslesscut-losslesscut branch from 7145007 to 92c2e0e Compare November 11, 2024 06:57
@weblate weblate force-pushed the weblate-losslesscut-losslesscut branch from 92c2e0e to aae3d13 Compare November 19, 2024 04:23
@weblate weblate force-pushed the weblate-losslesscut-losslesscut branch 5 times, most recently from 6c06a7a to 9bac9a2 Compare December 4, 2024 11:18
@weblate weblate force-pushed the weblate-losslesscut-losslesscut branch 8 times, most recently from 1a2f819 to 1fcdb19 Compare December 11, 2024 06:08
@weblate weblate force-pushed the weblate-losslesscut-losslesscut branch 5 times, most recently from f10a726 to 6b6f2b0 Compare December 21, 2024 09:18
@weblate weblate force-pushed the weblate-losslesscut-losslesscut branch from 6b6f2b0 to d6fd3c8 Compare December 28, 2024 06:01
@weblate weblate force-pushed the weblate-losslesscut-losslesscut branch 4 times, most recently from 623330d to 9662ea3 Compare January 24, 2025 09:59
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9662ea3 and 04b5797.

📒 Files selected for processing (1)
  • locales/pl/translation.json (1 hunks)
🔇 Additional comments (7)
locales/pl/translation.json (7)

742-743: LGTM! Clear and accurate translations.

The translations for "No file is loaded" and "Smart cut is experimental..." are accurate and maintain the same meaning as the English versions.


744-747: LGTM! Technical terms are correctly preserved.

The translations maintain technical terms like "FFmpeg", "MP4", "MOV" unchanged while accurately translating the surrounding context.


754-758: LGTM! Consistent translations for UI elements.

The translations maintain consistency in UI terminology and preserve the technical terms in quotes.


763-777: LGTM! Consistent translations for navigation terms.

The translations for seek operations, file operations, and UI elements are accurate and maintain consistency.


778-782: LGTM! Technical explanation properly translated.

The translation maintains the technical accuracy while being clear in Polish.


752-753: ⚠️ Potential issue

Fix variable placeholder in translation.

The translation on line 752 has incorrect spacing around the variable placeholder. There should be no spaces inside the curly braces.

-"At least one resulting file name contains invalid character(s): {{ invalidChars }}": "Co najmniej jedna wynikowa nazwa pliku zawiera nieprawidłowe znaki: {{invalidChars}}",
+"At least one resulting file name contains invalid character(s): {{invalidChars}}": "Co najmniej jedna wynikowa nazwa pliku zawiera nieprawidłowe znaki: {{invalidChars}}",

Likely invalid or redundant comment.


783-858: Verify plural forms handling.

The translations include plural forms (e.g., "frames_one", "frames_other"). Verify that Polish plural forms are correctly handled.

✅ Verification successful

Polish plural forms are correctly implemented

The translations use appropriate Polish grammatical forms for both singular ("_one") and plural ("_other") cases. While Polish has complex plural rules, the current implementation correctly handles the basic cases within the constraints of the i18next framework.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check for plural form keys and their translations
rg "_one|_other" locales/pl/translation.json

Length of output: 1283

Comment on lines +759 to +762
"Select segments by expression": "Wybierz segmenty wg wyrażenia",
"Whether to preserve chapters from source file.": "Określa do zachowania rozdziałów z pliku źródłowego.",
"Whether to preserve metadata from source file. Default: Global (file metadata), per-track and per-chapter metadata will be copied. Non-global: Only per-track and per-chapter metadata will be copied. None: No metadata will be copied": "Określa, czy zachować metadane z pliku źródłowego. Wartość domyślna: Kopiowane będą metadane globalne (metadane pliku), metadane poszczególnych ścieżek i rozdziałów. Nieglobalne: kopiowane będą tylko metadane poszczególnych utworów i rozdziałów. Brak: żadne metadane nie zostaną skopiowane",
"You have enabled the \"invert segments\" mode <1></1> which will cut away selected segments instead of keeping them. But there is no space between any segments, or at least two segments are overlapping. This would not produce any output. Either make room between segments or click the Yinyang <3></3> symbol below to disable this mode. Alternatively you may combine overlapping segments from the menu.": "Włączyłeś opcję \"odwróć segmenty\" tryb <1></1>, który wytnie wybrane segmenty zamiast je zachować. Pomiędzy segmentami nie ma jednak odstępu lub co najmniej dwa segmenty nakładają się na siebie. Nie spowoduje to żadnego wyjścia. Zrób miejsce między segmentami lub kliknij symbol Yinyang <3></3> poniżej, aby wyłączyć ten tryb. Alternatywnie można połączyć nakładające się segmenty z menu.",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix HTML tags in translation.

The translations contain HTML tags that should be preserved exactly as in the source. Ensure the spacing around tags matches the original.

-"You have enabled the \"invert segments\" mode <1></1> which will cut away selected segments instead of keeping them...": "Włączyłeś opcję \"odwróć segmenty\" tryb <1></1>, który wytnie wybrane segmenty zamiast je zachować...",
+"You have enabled the \"invert segments\" mode <1></1> which will cut away selected segments instead of keeping them...": "Włączyłeś tryb \"odwróć segmenty\" <1></1>, który wytnie wybrane segmenty zamiast je zachować...",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"Select segments by expression": "Wybierz segmenty wg wyrażenia",
"Whether to preserve chapters from source file.": "Określa do zachowania rozdziałów z pliku źródłowego.",
"Whether to preserve metadata from source file. Default: Global (file metadata), per-track and per-chapter metadata will be copied. Non-global: Only per-track and per-chapter metadata will be copied. None: No metadata will be copied": "Określa, czy zachować metadane z pliku źródłowego. Wartość domyślna: Kopiowane będą metadane globalne (metadane pliku), metadane poszczególnych ścieżek i rozdziałów. Nieglobalne: kopiowane będą tylko metadane poszczególnych utworów i rozdziałów. Brak: żadne metadane nie zostaną skopiowane",
"You have enabled the \"invert segments\" mode <1></1> which will cut away selected segments instead of keeping them. But there is no space between any segments, or at least two segments are overlapping. This would not produce any output. Either make room between segments or click the Yinyang <3></3> symbol below to disable this mode. Alternatively you may combine overlapping segments from the menu.": "Włączyłeś opcję \"odwróć segmenty\" tryb <1></1>, który wytnie wybrane segmenty zamiast je zachować. Pomiędzy segmentami nie ma jednak odstępu lub co najmniej dwa segmenty nakładają się na siebie. Nie spowoduje to żadnego wyjścia. Zrób miejsce między segmentami lub kliknij symbol Yinyang <3></3> poniżej, aby wyłączyć ten tryb. Alternatywnie można połączyć nakładające się segmenty z menu.",
"Select segments by expression": "Wybierz segmenty wg wyrażenia",
"Whether to preserve chapters from source file.": "Określa do zachowania rozdziałów z pliku źródłowego.",
"Whether to preserve metadata from source file. Default: Global (file metadata), per-track and per-chapter metadata will be copied. Non-global: Only per-track and per-chapter metadata will be copied. None: No metadata will be copied": "Określa, czy zachować metadane z pliku źródłowego. Wartość domyślna: Kopiowane będą metadane globalne (metadane pliku), metadane poszczególnych ścieżek i rozdziałów. Nieglobalne: kopiowane będą tylko metadane poszczególnych utworów i rozdziałów. Brak: żadne metadane nie zostaną skopiowane",
"You have enabled the \"invert segments\" mode <1></1> which will cut away selected segments instead of keeping them. But there is no space between any segments, or at least two segments are overlapping. This would not produce any output. Either make room between segments or click the Yinyang <3></3> symbol below to disable this mode. Alternatively you may combine overlapping segments from the menu.": "Włączyłeś tryb \"odwróć segmenty\" <1></1>, który wytnie wybrane segmenty zamiast je zachować. Pomiędzy segmentami nie ma jednak odstępu lub co najmniej dwa segmenty nakładają się na siebie. Nie spowoduje to żadnego wyjścia. Zrób miejsce między segmentami lub kliknij symbol Yinyang <3></3> poniżej, aby wyłączyć ten tryb. Alternatywnie można połączyć nakładające się segmenty z menu.",

Comment on lines +748 to +751
"Fastest: FFmpeg-assisted playback": "Najszybsze: FFmpeg-assisted playback",
"You can customize the file name of the merged file using special variables.": "Możesz dostosować nazwę pliku scalonego pliku za pomocą specjalnych zmiennych.",
"Seek one frame": "Szukaj jednej klatki",
"<0>If you're having a problem or question about LosslessCut, please first check the links in the <1>Help</1> menu. If you cannot find any resolution, you may ask a question in <3>GitHub discussions</3> or on <5>Discord.</5></0><1>If you believe that you found a bug in LosslessCut, you may <1>report a bug</1>.</1>": "<0>Jeśli masz problem lub pytanie dotyczące LosslessCut, najpierw sprawdź linki w menu<1>Pomoc</1>. Jeśli nie możesz znaleźć żadnej decyzji, możesz zadać pytanie w <3> dyskusjach GitHub </3> lub na<5>Discord.</5> </0> <1> Jeśli uważasz, że znalazłeś błąd w LosslessCut , możesz zgłosić błąd </1>. </1>",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

"FFmpeg-assisted playback" should be partially translated in Polish

The term should follow the pattern used in other locales where "FFmpeg" remains untranslated while "assisted playback" is translated. Consider translating it to "odtwarzanie wspomagane przez FFmpeg" or similar, consistent with how other languages handle this technical term.

🔗 Analysis chain

Verify the translation of technical feature names.

While most translations are accurate, "FFmpeg-assisted playback" is left untranslated on line 748. Consider whether this is intentional for technical terms.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check if other language files also keep "FFmpeg-assisted playback" untranslated
rg -l "FFmpeg-assisted playback" locales/

Length of output: 501


Script:

#!/bin/bash
# Extract the full line containing "FFmpeg-assisted playback" from all locale files
rg "FFmpeg-assisted playback" locales/

Length of output: 3171

@weblate weblate force-pushed the weblate-losslesscut-losslesscut branch 2 times, most recently from b1d34eb to af7bad1 Compare January 31, 2025 16:05
gallegonovato and others added 13 commits February 1, 2025 14:39
Currently translated at 100.0% (767 of 767 strings)

Translation: LosslessCut/LosslessCut
Translate-URL: https://hosted.weblate.org/projects/losslesscut/losslesscut/es/
Currently translated at 100.0% (767 of 767 strings)

Translation: LosslessCut/LosslessCut
Translate-URL: https://hosted.weblate.org/projects/losslesscut/losslesscut/ru/
Currently translated at 100.0% (767 of 767 strings)

Translation: LosslessCut/LosslessCut
Translate-URL: https://hosted.weblate.org/projects/losslesscut/losslesscut/zh_Hans/
Currently translated at 100.0% (767 of 767 strings)

Translation: LosslessCut/LosslessCut
Translate-URL: https://hosted.weblate.org/projects/losslesscut/losslesscut/it/
Currently translated at 100.0% (767 of 767 strings)

Translation: LosslessCut/LosslessCut
Translate-URL: https://hosted.weblate.org/projects/losslesscut/losslesscut/ja/
Currently translated at 100.0% (767 of 767 strings)

Translation: LosslessCut/LosslessCut
Translate-URL: https://hosted.weblate.org/projects/losslesscut/losslesscut/cs/
Currently translated at 100.0% (767 of 767 strings)

Translation: LosslessCut/LosslessCut
Translate-URL: https://hosted.weblate.org/projects/losslesscut/losslesscut/sk/
Currently translated at 100.0% (767 of 767 strings)

Translation: LosslessCut/LosslessCut
Translate-URL: https://hosted.weblate.org/projects/losslesscut/losslesscut/cs/
Currently translated at 100.0% (767 of 767 strings)

Translation: LosslessCut/LosslessCut
Translate-URL: https://hosted.weblate.org/projects/losslesscut/losslesscut/de/
Currently translated at 100.0% (767 of 767 strings)

Translation: LosslessCut/LosslessCut
Translate-URL: https://hosted.weblate.org/projects/losslesscut/losslesscut/es/
Currently translated at 100.0% (767 of 767 strings)

Translation: LosslessCut/LosslessCut
Translate-URL: https://hosted.weblate.org/projects/losslesscut/losslesscut/ta/
Currently translated at 100.0% (767 of 767 strings)

Translation: LosslessCut/LosslessCut
Translate-URL: https://hosted.weblate.org/projects/losslesscut/losslesscut/pl/
@weblate weblate force-pushed the weblate-losslesscut-losslesscut branch from af7bad1 to 47008e3 Compare February 1, 2025 14:39
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
locales/pl/translation.json (1)

751-751: Review Help Message Translation:
The help message translation on this line uses “... nie możesz znaleźć żadnej decyzji …”. The term “decyzji” appears to be a mistranslation of “resolution” and should likely be replaced with “rozwiązania” for better clarity. Also, check spacing around the tagged elements (e.g., ensure a space exists before <1>Pomoc</1>).

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between af7bad1 and 47008e3.

📒 Files selected for processing (9)
  • locales/cs/translation.json (2 hunks)
  • locales/de/translation.json (1 hunks)
  • locales/es/translation.json (2 hunks)
  • locales/it/translation.json (1 hunks)
  • locales/ja/translation.json (1 hunks)
  • locales/pl/translation.json (1 hunks)
  • locales/ru/translation.json (1 hunks)
  • locales/sk/translation.json (1 hunks)
  • locales/zh_Hans/translation.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (7)
  • locales/de/translation.json
  • locales/it/translation.json
  • locales/sk/translation.json
  • locales/ru/translation.json
  • locales/cs/translation.json
  • locales/ja/translation.json
  • locales/zh_Hans/translation.json
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: test (windows-latest)
🔇 Additional comments (4)
locales/pl/translation.json (3)

742-747: New Translation Entries Added:
This block adds several new user messages (e.g., “No file is loaded”, “Smart cut is experimental…”, etc.) that improve clarity in error and process feedback. Please verify these entries align with the project’s overall terminology and style.


748-748: Technical Term Translation Issue:
The entry
  "Fastest: FFmpeg-assisted playback": "Najszybsze: FFmpeg-assisted playback"
leaves the technical phrase “FFmpeg-assisted playback” fully in English. For consistency with other locales, consider partially translating it—preserving “FFmpeg” while translating “assisted playback” (e.g., to "odtwarzanie wspomagane przez FFmpeg").


752-762: Overall Consistency and Clarity:
The remaining entries in this block—covering messages about invalid file names, codec support, importing chapters, and preserving metadata—are clear and consistent with broader project terminology. It would be good to double-check punctuation and any special formatting to ensure they match similar entries in other locale files.

locales/es/translation.json (1)

906-909: New Spanish Translation Entries:
The added Spanish entries for:
 • "File name is too long and cannot be exported."
 • "Adjusting the output FPS and cutting at the same time will cause incorrect cuts. Consider instead doing it in two separate steps."
 • "Fell back to default output file name"
are clear, concise, and consistent with corresponding updates across other languages. The messaging effectively informs the users and adheres to the project’s tone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants