Change simulator UI help text to refer to directory #839
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the mode of the simulator in which you provide an existing `index.json` file, the help text said to provide the absolute path to the `index.json` file. However if you do so, the string `index.json` is then appended to this leading to errors such as: ``` RuntimeError: No `remote` provided, but local file /home/scott/scratch/dummy-mds-dataset/index.json/index.json does not exist either ``` This PR changes the help text to instruct the user to provide the path to the directory containing the `index.json` file, instead of to the file itself.
srstevenson
force-pushed
the
srs/change-simulator-ui-help-text-to
branch
from
37a3e30 to
13333da
Compare
|
@srstevenson ah thanks, nice catch! lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the mode of the simulator in which you provide an existing
index.jsonfile, the help text said to provide the absolute path to theindex.jsonfile. However if you do so, the stringindex.jsonis then appended to this leading to errors such as:This PR changes the help text to instruct the user to provide the path to the directory containing the
index.jsonfile, instead of to the file itself.Before:
After:
