Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Gazebo in tutorial image Dockerfile #2952

Merged
merged 3 commits into from
Aug 6, 2024
Merged

Conversation

sea-bass
Copy link
Contributor

@sea-bass sea-bass commented Aug 6, 2024

Description

This is the equivalent of moveit/moveit2_tutorials#937, but for this repo. Should hopefully make CI green.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@sea-bass
Copy link
Contributor Author

sea-bass commented Aug 6, 2024

Hmm... seems like the gz_plugin_vendor package is only available on Jazzy and Rolling, so it's only going to fix it for that.

To support humble/iron, we'll need to pull in different versions of the ros2_kortex repo, that don't transitively depend on the gz_ros2_control package.

Copy link
Contributor

@sjahr sjahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for digging into this! Fixing at least jazzy and rolling is a big step forward 🎉

@sea-bass sea-bass added this pull request to the merge queue Aug 6, 2024
Merged via the queue into main with commit 4ad84cc Aug 6, 2024
21 of 24 checks passed
@sea-bass sea-bass deleted the fix-tutorial-docker-build branch August 6, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants