Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation refresh #14966

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

wen-2018
Copy link
Collaborator

@wen-2018 wen-2018 commented Aug 15, 2024

One-line summary

Significant changes and points to review

Issue / Bugzilla link

#14827

Testing

@wen-2018 wen-2018 added the WIP 🚧 Pull request is still work in progress label Aug 18, 2024
@stephaniehobson stephaniehobson added the Refresh 🦖 Work related to the 2024 site refresh label Aug 19, 2024
bedrock/settings/base.py Outdated Show resolved Hide resolved
@wen-2018 wen-2018 force-pushed the refresh-header-navigation branch 3 times, most recently from 440769a to b88f952 Compare August 27, 2024 19:22
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.83%. Comparing base (3615a24) to head (412fb6d).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14966   +/-   ##
=======================================
  Coverage   77.83%   77.83%           
=======================================
  Files         162      162           
  Lines        8458     8459    +1     
=======================================
+ Hits         6583     6584    +1     
  Misses       1875     1875           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wen-2018 wen-2018 force-pushed the refresh-header-navigation branch 3 times, most recently from 670df45 to 095f52f Compare August 28, 2024 17:46
@stephaniehobson stephaniehobson added the Frontend HTML, CSS, JS... client side stuff label Aug 30, 2024
@wen-2018 wen-2018 force-pushed the refresh-header-navigation branch 5 times, most recently from d20866f to bd6573c Compare September 5, 2024 20:22
@wen-2018 wen-2018 force-pushed the refresh-header-navigation branch 4 times, most recently from 9e4dcd1 to 7a214f6 Compare September 11, 2024 21:07
@wen-2018 wen-2018 force-pushed the refresh-header-navigation branch 5 times, most recently from 5f01330 to 2788908 Compare September 13, 2024 17:20
Copy link
Contributor

@janbrasna janbrasna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm aware this is still a draft, but just to make sure it won't hit the l10n review eventually: I've noticed the Relay brand missing (and some more ftl cosmetics around it…)

l10n/en/navigation_refresh.ftl Outdated Show resolved Hide resolved
l10n/en/navigation_refresh.ftl Outdated Show resolved Hide resolved
l10n/en/navigation_refresh.ftl Outdated Show resolved Hide resolved
Copy link
Contributor

@stephaniehobson stephaniehobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a quick look and made some notes. This is looking great and so close to ready :)

l10n/en/navigation_refresh.ftl Outdated Show resolved Hide resolved
l10n/en/navigation_refresh.ftl Outdated Show resolved Hide resolved
l10n/en/navigation_refresh.ftl Outdated Show resolved Hide resolved
media/css/m24/components/navigation-refresh.scss Outdated Show resolved Hide resolved
@wen-2018 wen-2018 marked this pull request as ready for review September 13, 2024 20:03
@wen-2018 wen-2018 removed the WIP 🚧 Pull request is still work in progress label Sep 13, 2024
Copy link
Contributor

@stephaniehobson stephaniehobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R+ 🔽

I know there's some refactoring you want to do but this looks and works great now. We can do code clean up in a follow up PR.

@stephaniehobson stephaniehobson merged commit cf21cf2 into mozilla:main Sep 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend HTML, CSS, JS... client side stuff Refresh 🦖 Work related to the 2024 site refresh
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants