-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation refresh #14966
Navigation refresh #14966
Conversation
440769a
to
b88f952
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14966 +/- ##
=======================================
Coverage 77.83% 77.83%
=======================================
Files 162 162
Lines 8458 8459 +1
=======================================
+ Hits 6583 6584 +1
Misses 1875 1875 ☔ View full report in Codecov by Sentry. |
670df45
to
095f52f
Compare
d20866f
to
bd6573c
Compare
9e4dcd1
to
7a214f6
Compare
5f01330
to
2788908
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm aware this is still a draft, but just to make sure it won't hit the l10n review eventually: I've noticed the Relay brand missing (and some more ftl cosmetics around it…)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a quick look and made some notes. This is looking great and so close to ready :)
2788908
to
3e32563
Compare
3e32563
to
412fb6d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
R+ 🔽
I know there's some refactoring you want to do but this looks and works great now. We can do code clean up in a follow up PR.
One-line summary
Significant changes and points to review
Issue / Bugzilla link
#14827
Testing