Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: Fix output depth struct #30514

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Feb 13, 2025

Fixes #30476

Description

Fix output depth when used outputStruct().

@sunag sunag added this to the r174 milestone Feb 13, 2025
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.42
78.33
336.42
78.33
+0 B
+0 B
WebGPU 518.01
143.92
518
143.91
-17 B
-11 B
WebGPU Nodes 517.48
143.81
517.46
143.8
-17 B
-11 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.41
112.17
465.41
112.17
+0 B
+0 B
WebGPU 589.89
160.02
589.87
160
-17 B
-14 B
WebGPU Nodes 545.26
149.56
545.24
149.54
-17 B
-15 B

@sunag sunag marked this pull request as ready for review February 13, 2025 06:32
@sunag sunag merged commit f640829 into mrdoob:dev Feb 13, 2025
12 checks passed
@sunag sunag deleted the dev-fix-depth-output branch February 13, 2025 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant