Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: Fix output depth struct #30514

Merged
merged 1 commit into from
Feb 13, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 6 additions & 13 deletions src/renderers/webgpu/nodes/WGSLNodeBuilder.js
Original file line number Diff line number Diff line change
Expand Up @@ -789,19 +789,6 @@ class WGSLNodeBuilder extends NodeBuilder {

}

/**
* Returns uniforms group count for the given shader stage.
*
* @private
* @param {string} shaderStage - The shader stage.
* @return {number} The uniforms group count for the given shader stage.
*/
_getUniformGroupCount( shaderStage ) {

return Object.keys( this.uniforms[ shaderStage ] ).length;

}

/**
* Returns the native shader operator name for a given generic name.
*
Expand Down Expand Up @@ -1449,6 +1436,12 @@ ${ flowData.code }

}

if ( struct.output ) {

snippets.push( `\t${ this.getBuiltins( 'output' ) }` );

}

return snippets.join( ',\n' );

}
Expand Down