Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install dask lab ext from main #1321

Merged
merged 2 commits into from
Jun 14, 2022
Merged

install dask lab ext from main #1321

merged 2 commits into from
Jun 14, 2022

Conversation

iameskild
Copy link
Member

Fixes | Closes | Resolves #1012

Please remove anything marked as optional that you don't need to fill in.
Choose one of the keywords preceding to refer to the issue this PR solves, followed by the issue number (e.g Fixes # 666).
If there is no issue, remove the line. Remove this note after reading.

Changes introduced in this PR:

Types of changes

What types of changes does your PR introduce?

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

Documentation

Does your contribution include breaking changes or deprecations?
If so have you updated the documentation?

  • Yes, docstrings
  • Yes, main documentation
  • Yes, deprecation notices

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered and more.

This updated jupyterlab image has already been added to beta deployment if anyone wants to test it out. We needed this for the demon on Monday.

To enable the extension try:

  • Settings > Advanced settings Editor > Dask
  • There will be a box called "Determine whether to validate dashboards via browser check".
  • Just check that and this will update the extension.

@viniciusdc is there a way to automatically enable the extention?

@viniciusdc
Copy link
Contributor

Yes there is #1012 (comment)

@viniciusdc
Copy link
Contributor

I can have this automatically set by tomorrow, I was hoping to get this by today but lost track of time. Let me know if this is acceptable

@iameskild iameskild added area: integration/Dask Issues related to Dask on QHub area: JupyterLab needs: changes 🧱 Review completed - some changes are needed before merging labels Jun 9, 2022
Copy link
Contributor

@viniciusdc viniciusdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@viniciusdc viniciusdc added status: merge-ready and removed needs: changes 🧱 Review completed - some changes are needed before merging labels Jun 14, 2022
@iameskild iameskild merged commit dd4012f into main Jun 14, 2022
@iameskild iameskild deleted the dask_labext branch June 14, 2022 16:11
@ian-r-rose
Copy link

Sorry to be slow in publishing, this feature should now be available from pypi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: integration/Dask Issues related to Dask on QHub area: JupyterLab
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Unable to connect to dashboard using Dask-Gateway and Labextension
4 participants