Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USS Mayflower #653

Closed
wants to merge 1 commit into from
Closed

USS Mayflower #653

wants to merge 1 commit into from

Conversation

VividPups
Copy link
Contributor

@VividPups VividPups commented Dec 4, 2023

About the PR

Adds a New Expedition/Bounty hunter ship. The USS Mayflower

Why / Balance

As far as I was able to see the only Bounty hunter/Expedition ship was the KC Sprinter. So I would like to add more that is more dedicated in bounty hunting/ Expeditions

Technical details

Media

image

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

🆑

  • add: Added The USS Mayflower

@dvir001
Copy link
Contributor

dvir001 commented Dec 4, 2023

image
Names need to match, lowercase only

Also remove you SLN file

Copy link
Contributor

@dvir001 dvir001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ship has alot of security gear and gamery gear as of now.

stationProto: StandardFrontierExpeditionVessel
components:
- type: StationNameSetup
mapNameTemplate: 'USS Mayflower{1}'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name format missing space

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you mean by that? Where is the space post to be at?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you mean by that? Where is the space post to be at?

between Mayflower and {1}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooo ok also... i just want to say I appearnlty mess this up really big so I am right now fixing all of this with the help of minty

Resources/Maps/Shuttles/Mushroom.yml Show resolved Hide resolved
- canCollide: False
type: Physics
- type: InsideEntityStorage
- proto: ClothingOuterCoatHoSTrench
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hos gear?? this is sec gear.

Copy link
Contributor Author

@VividPups VividPups Dec 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can buy the sheriffs hat from an BountyVending(at the lodge) and the trenchcoat is just renamed like it is on the sprinter

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its getting fixed, the hat will need to get a new version with a new name..
Ill look into adding the 2 as new versions to be used for it, might as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i believe its in now with the merc gear rework

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have change the custom bounty hunter name hos cloths To actual Bounty hunter cloths

Resources/Maps/Shuttles/Mushroom.yml Show resolved Hide resolved
- pos: -5.5,-1.5
parent: 1
type: Transform
- proto: ClothingUniformJumpskirtDetective
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detective gear?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the hard worn suit is an jumpsuit that you can buy from the repdrobe that all civils have access too and its on the sprinter ship another Expedition ship

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these has been corrected

- canCollide: False
type: Physics
- type: InsideEntityStorage
- proto: ClothingUniformJumpsuitDetective
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detective gear?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the hard worn suit you can buy from the Repdrobe and its on the sprinter ship

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we've re-done most of these, we now have much more mercenary-specific gear you should use instead, including new acceptable variants of like, the bounty hunter drip

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has been change to bounty

- ShutdownSubscribers:
- 460
type: DeviceNetwork
- proto: FloorDrain
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drain in a merc and medical ship?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well the sprinter has one including the dart, anchor even tho the dart and anchor isnt an merc ship

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i do regret adding the drains to those ships. Drains are very powerful entities right now and I kind of want to avoid mapping them, except for pretty much cloning areas and kitchen freezer areas. Chemists puddle gameplay should be a part of the whole thing.

Copy link
Contributor Author

@VividPups VividPups Dec 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drain has been removed ( I think it crash again like 2 more times

Resources/Maps/Shuttles/Mushroom.yml Show resolved Hide resolved
Resources/Maps/Shuttles/Mushroom.yml Show resolved Hide resolved
Resources/Maps/Shuttles/Mushroom.yml Show resolved Hide resolved
@Cheackraze
Copy link
Member

we are indeed in the middle of reworking how weapons and such are given through ships. We are about to have 'gun lockers' in 3 tiers, corresponding to the ship's value, so it would be best not to map individual guns right now in favor of those cabinets in order to keep it in line with the rest. To be fair, however, we did determine that Kammerers are more of an advanced-civilian weapon in their current state, with the Security grade shotgun becoming the enforcer.

Also, the 'bounty hunter' variants of the items found on the sprinter, are now official spawned entities you can use again. I super appreciate your patience here, but We've been working to add the things to make sure this ship can be everything its designed to be! Looking forward to a possible update

@VividPups
Copy link
Contributor Author

VividPups commented Dec 13, 2023

@Cheackraze I do appreciate the responses with the extra info about what is going on behind the scenes and what is to come, I am sure you can tell by now that the USS Mayflower was Heavily influenced by the Sprinter and I wanted to make more Bounty Hunter style ships. Now at this point I kinda of stepped away from SS13 as a whole due to some stuff that has happened on SS14 I made it clear to some people that there is a good chance I won't return. However, I would still like to continue to at least finish this ship and it seems like the best Course of action is to wait for some of those things to be released

@Cheackraze
Copy link
Member

@Cheackraze I do appreciate the responses with the extra info about what is going on behind the scenes and what is to come, I am sure you can tell by now that the USS Mayflower was Heavily influenced by the Sprinter and I wanted to make more Bounty Hunter style ships. Now at this point I kinda of stepped away from SS13 as a whole due to some stuff that has happened on SS14 I made it clear to some people that there is a good chance I won't return. However, I would still like to continue to at least finish this ship and it seems like the best Course of action is to wait for some of those things to be released

all of the mercenary gear has been updated, feel free to update the shuttle with the new items so I can merge it. Let me know or ask on discord if you need help merging the latest updates into your working branch, so that you get access to the new items.

@Cheackraze
Copy link
Member

so, full review on whats presented. I have 2 issues with it overall, but they are mostly minor. One is the lack of dirt. Since the theme here is abandoned/cobweb infested/broken down, I feel that adding (cleanable) dirt decals throughout the ship will really bring it all together. And second, is the use of kitty corner wall design.

mayflower

Although its tempting to try to save space using this, it has a poor visual effect on the walls and lighting system in the game. With icon smoothing on walls, you get strange looking walls and can 'see' on the other side of the walls where it doesnt connect and looks bad. Another issue is just the fact that it creates weak points in the design, and have the potential to react funky with projectiles passing 'through' that point in the wall. Among other things. I feel that you definitely have plenty of space inside the ship to adjust some of the rooms and shapes to avoid this issue, while still keeping true to your design goals 100%. Otherwise, I like the design and idea behind it, and this will likely join the bison and SV series shuttles (maybe a few others like kestrel, maybe pathfinder...) in a 'scrapyard' shipyard catalogue.

@VividPups
Copy link
Contributor Author

So pretty much what happened was. I appeared wasn't doing it right in a way where I couldn't update the local server with the new release stuff. Which in respond. I had to create a new Ship file for the game shipyard (which now when I buy from the shipyard it just freezes the game completely). However. I changed the Kitty Corners mark on the picture and added dirt to all the tiles. so it look more broken down and old. At this point I have no idea what is causing the crashing now. I had ask the discord about it and right now as of now they don't know why it is crashing

@VividPups
Copy link
Contributor Author

VividPups commented Dec 20, 2023

Ok I fix it and as I try to figure out how to update all of this Have an Updated look of the ship
Mayflower

Ok I fix it and as I try to figure out how to update all of this Have an Updated look of the ship

@VividPups
Copy link
Contributor Author

Ok, I think I did it but not sure?

@dvir001
Copy link
Contributor

dvir001 commented Dec 20, 2023

Ok, I think I did it but not sure?

Did you forget to push the changes to this PR?
If you are using GitHub Desktop make sure to click push to update
CLI is about the same just command it

@VividPups
Copy link
Contributor Author

I did Press Push multiple times and I guess it didn't work...I'll try again after work and if there isn't any change I'll make a new. I believe with how much the change happen last night with it could be the problem.

@VividPups
Copy link
Contributor Author

So with the Push failing so much. I am just going to close this one and then make a new one with the updated everything since for some reason this one isn't updating

@VividPups
Copy link
Contributor Author

So I am getting an Push failed error (trying to make the new one)
... Unable to Push to the remote repositiory because your local branch is behind the remote branch. Update your branch by pulling before pushing.

but both of the pulling is gray out and im not sure how to fix that

@VividPups
Copy link
Contributor Author

VividPups commented Dec 21, 2023

At this point im at a lost.. and don't know what to do to be able to make the new Pull request since this one isn't allowing me to update it. now the new one I am trying to make is saying I'm making no changes from the looks of it

@VividPups
Copy link
Contributor Author

#734 (comment)

Link to the new Request with the updates that was ask/told to do.

@VividPups VividPups closed this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants