merge: polish #1591
Merged
merge: polish #1591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1591 +/- ##
==========================================
+ Coverage 70.51% 70.56% +0.04%
==========================================
Files 78 78
Lines 8107 8119 +12
Branches 1966 1967 +1
==========================================
+ Hits 5717 5729 +12
Misses 2100 2100
Partials 290 290 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
This is a small thing, really, but it's a detail that helps make error messages more precise and thus potentially less confusing. It's easy enough, so take the care to do it.
Format defaults so they're formatted for the shell like would be seen/input on the command-line by humans instead of as a Python value. Rephrases default for argument-less --quiet flag. Suppresses "(default: None)" for required options.
tsibley
force-pushed
the
trs/merge/polish
branch
from
e13659b to
de1bf9a
Compare
|
Rebased onto latest |
|
One more bit of error polishing coming in a few minutes… |
Demonstrates the current (not ideal) error message.
This message in Metadata() now matches the error message for the same condition in read_metadata(), which is a big improvement to the "say what now??" quotient. It seems like Metadata's _find_first() implementation was intentionally made generic thus requiring a generic error message, but it's only used in a single place, to find the id column, so make it specific and thus clearer.
… error messages The tuple(…)!r trick is cute but leaves single-item lists with a trailing comma.
victorlin
approved these changes
Aug 21, 2024
This was referenced Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages.
Checklist