Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transition animation when panel options are shown/hidden #1724

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented Nov 15, 2023

Description of proposed changes

Suggested by @ivan-aksamentov on Slack.

Related issue(s)

Checklist

This currently has two problems:

1. It does not allow dropdowns from within the options to render lower
   than the boundaries.
2. It transitions the height from viewport height to 0, however all the
   actual panel option divs are shorter than that. This means there is a
   delay before the transition makes a visible change, and the speed is
   much faster than if it went from panel option div's height to 0.

(2) is more of a nuisance and can be addressed by dynamically setting
the max-height based on the containing div's scrollHeight, however (1)
is the prevailing and blocking problem.
@victorlin victorlin self-assigned this Nov 15, 2023
@nextstrain-bot nextstrain-bot temporarily deployed to auspice-victorlin-panel-mz1k9o November 15, 2023 00:22 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants