Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add transition animation when panel options are shown/hidden #1724

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Add transition animation when panel options are shown/hidden #1724

wants to merge 2 commits into from

Commits on Nov 15, 2023

  1. 🚧 Add transition when toggling panel transitions 

    This currently has two problems:

1. It does not allow dropdowns from within the options to render lower
   than the boundaries.
2. It transitions the height from viewport height to 0, however all the
   actual panel option divs are shorter than that. This means there is a
   delay before the transition makes a visible change, and the speed is
   much faster than if it went from panel option div's height to 0.

(2) is more of a nuisance and can be addressed by dynamically setting
the max-height based on the containing div's scrollHeight, however (1)
is the prevailing and blocking problem.
    @victorlin
    victorlin committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    92d66ea View commit details
    Browse the repository at this point in the history

  2. Dynamically calculate heights of panel option containers

    @victorlin
    victorlin committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    1c26491 View commit details
    Browse the repository at this point in the history