Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bumped MultiQC version for dumpsoftwareversions #6224

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

harper357
Copy link

PR checklist

This just updates dumpsoftwareversions to the latest version of theMultiQC container.

  • This comment contains a description of changes (with reason).
  • Emit the versions.yml file.
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda

Running the test fails because the versions are updated in the container, I am not sure how you usually go about updating the test.

@jfy133
Copy link
Member

jfy133 commented Aug 21, 2024

I wonder if this could also be replaced with the ubuntu container... I wonder if that has a basic python installation?

@harper357
Copy link
Author

I tried to run the ubuntu container but python is not installed in it

@jfy133
Copy link
Member

jfy133 commented Aug 22, 2024

@maxulysse pointed out that we don't use this anymore, but instead with a function in the template. He wondered if we should deprecate it.

@SPPearce
Copy link
Contributor

So, do we want to deprecate this?

@jfy133
Copy link
Member

jfy133 commented Sep 16, 2024

I don't know if we have a deprecation procedure do we?

@SPPearce
Copy link
Contributor

I don't know if we have a deprecation procedure do we?

Oh James, I thought you knew the guidelines 😉.

@SPPearce
Copy link
Contributor

@jfy133
Copy link
Member

jfy133 commented Sep 18, 2024

I don't know if we have a deprecation procedure do we?

Oh James, I thought you knew the guidelines 😉.

OH nice! Then yes, lets deprecate :)

@SPPearce
Copy link
Contributor

Added a message. I don't know what happens to the tests at that point, but they seem to be fine for the other modules so maybe they just ignore the assert?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants