-
Notifications
You must be signed in to change notification settings - Fork 747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New subworkflow: Fastq_fastp_trim_fastqc #3146
New subworkflow: Fastq_fastp_trim_fastqc #3146
Conversation
I we're sticking to the guidlines, I think the name should be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but should fix the tests first
That's possible, no problem in changing the name. I just took what was written down on nf-core/viralrecon#371 but think the best name would then be |
@nvnieuwk , you're the guideline specialist 😛 |
Looks good to me except for the comments in the main.nf file (they lack |
OOh no did I do it again 🙈? I know what you mean and address it. |
No problem that's what I'm here for ;) |
@nf-core-bot fix linting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Still not sure about the name though.
Ok, then if ur having doubts lets just change it to |
Awesome work 🚀 apologies for the confusion |
Old name was good 'The naming convention should be of the format <file_type><operation_1><operation_n><tool_1><tool_n>' from https://nf-co.re/docs/contributing/subworkflows#naming-conventions |
* master: Ngscheckmate (nf-core#3094) New module Mindagap (nf-core#2860) Coreograph Module (nf-core#3201) new module wisecondorx/newref (nf-core#3212) Add core detection test data to config (nf-core#3199) Collectinsertsizemetrics (nf-core#3179) update appropriate label for freyja boot (nf-core#3215) Emit files from uncompression utilities (nf-core#3144) new tool: art_illumina (nf-core#3162) Addition of new module: Issue nf-core#3113 Survivor/filter (nf-core#3168) Removed -1 in CPU size specification for samtools in BWA module (nf-core#3205) nf-test Transition CI (nf-core#3191) new module: sourmash/index (nf-core#3163) Chopper (nf-core#3174) Update mapdage2 module (nf-core#3185) Add imaging test data in config (nf-core#3190) New subworkflow: Fastq_fastp_trim_fastqc (nf-core#3146)
PR checklist
Addresses second bullet from nf-core/viralrecon#371
Adds the subworkflow Fastq_trim_fastp_fastqc used in nf-core/viralrecon to nf-core/modules
versions.yml
file.PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware