Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap samtools dict to nftest #5993

Merged
merged 5 commits into from
Jul 30, 2024
Merged

Swap samtools dict to nftest #5993

merged 5 commits into from
Jul 30, 2024

Conversation

SPPearce
Copy link
Contributor

No description provided.

@SPPearce SPPearce marked this pull request as ready for review July 18, 2024 10:36
@SPPearce SPPearce requested review from muffato and a team as code owners July 18, 2024 10:36
@SPPearce SPPearce requested review from kpadm and removed request for a team July 18, 2024 10:36
Copy link
Contributor

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment here

assertAll(
{ assert process.success },
{ assert snapshot(process.out.versions).match() },
{ assert path(process.out.dict[0][1]).readLines().first().contains("@HD\tVN:1.0\tSO:unsorted") }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you instead of this try to snapshot the stable lines of the file?

@SPPearce SPPearce enabled auto-merge July 30, 2024 18:10
@SPPearce SPPearce added this pull request to the merge queue Jul 30, 2024
Merged via the queue into master with commit 3c8fd07 Jul 30, 2024
12 checks passed
@SPPearce SPPearce deleted the samtools_dict branch July 30, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants