-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ichorcna to v0.5.1 and nf-test #6079
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - ichorcna no longer has a CLI, so it has been updated to use native R - Some additional parameters have been added - Requires scStates option in nextflow.config or it crashes
14 tasks
* change output directory * fix linting * update snapshot * update lane * delete environment.yml
* Updated test data paths * Added --depthcutoff for freyja/boot
Updated paths
* Updated paths * Updated shapshot for liftlong
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Updated test data paths batch 18 * Fixed instrain version in conda file * Fixed instrain version in conda file * Removed db content md5 from snapshot to pass conda test * Added samtools to instrain env * Updated snapshot
* Bump chromap version to chromap/index * Bump chromap version to chromap/chromap * Use nft-bam as suggested in review * Change how prefix for output index is set to be modifiable
* Update deeptools/plotheatmap * Update deeptols/multibamsummary * Update plotpca * Update deeptools/computematrix * Update deeptools/bamcoverage * Remove comment * Update deeptools/plotcorrelation * Fix c/p error * Update deeptools/plotfingerprint * Update nf-core/deeptools * Add deeptools/plotprofile snapshot * Simplify tests and fix some issues * Make lint happy * Make lint happy * Reverting plotheatmap meta.yml * Fix input declaration in meta yaml * Fix multibamsummary tags * Fix value type in meta.yml * Remove pytest for deeptools modules * Add missing tags in compound test runs * Fix tyop * Apply review suggestions * Update modules/nf-core/deeptools/bamcoverage/main.nf Co-authored-by: Simon Pearce <[email protected]> * Update snapshot for deeptools/bamcoverage after applying review suggestion * Change how prefix for output index is set to be modifiable * Revert last commit (wrong branch) :P --------- Co-authored-by: Simon Pearce <[email protected]>
* Allow for construction of standard database * Update meta to include standard database * Fix bug for passing in -l with ext.args * Full correction * Update test snapshots * Add test corresponding to the genus issue * Revert "Allow for construction of standard database" This reverts commit 71b800e. * Revert "Update meta to include standard database" This reverts commit 1d48333.
add nf-test to krakentools/combinekreports
adamrtalbot
approved these changes
Aug 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.