Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

krakentools/kreport2krona : fix meta.yml, port to nf-test #6082

Merged
merged 7 commits into from
Aug 3, 2024
Merged

krakentools/kreport2krona : fix meta.yml, port to nf-test #6082

merged 7 commits into from
Aug 3, 2024

Conversation

tstoeriko
Copy link
Contributor

@tstoeriko tstoeriko commented Aug 1, 2024 •
edited
Loading

This commit:

  • changes the meta.yml to match the output channel names in main.nf
  • ports the module to nf-test

PR checklist

Closes #6081

  • This comment contains a description of changes (with reason).

@tstoeriko
Update meta.yml
68fe086 
This commit changes the meta.yml to match the output channel names in main.nf
@SPPearce
Copy link
Contributor

SPPearce commented Aug 1, 2024

Any possibility you could migrate to nf-test?

@tstoeriko tstoeriko requested a review from a team as a code owner August 1, 2024 22:07
@tstoeriko tstoeriko requested review from louperelo and removed request for a team August 1, 2024 22:07
@tstoeriko tstoeriko changed the title krakentools/kreport2krona : fix meta.yml krakentools/kreport2krona : fix meta.yml, port to nf-test Aug 2, 2024
SPPearce
SPPearce approved these changes Aug 3, 2024
View reviewed changes
Copy link
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@SPPearce SPPearce added this pull request to the merge queue Aug 3, 2024
Merged via the queue into nf-core:master with commit ac3e1d7 Aug 3, 2024
12 checks passed
@tstoeriko tstoeriko deleted the krakentools_fixmeta branch August 3, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SPPearce SPPearce SPPearce approved these changes

@MillironX MillironX Awaiting requested review from MillironX

@louperelo louperelo Awaiting requested review from louperelo louperelo was automatically assigned from nf-core/nf-test

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

krakentools/kreport2krona : fix meta.yml
2 participants
@tstoeriko @SPPearce