Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump MetaPhlAn to 4.1.1 #6237

Closed
wants to merge 1 commit into from

Conversation

harper357
Copy link

PR checklist

This PR bumps the version of MetaPhlAn to 4.1.1 . There are currently no tests with this module, so I have not run the suggested docker test.

  • This comment contains a description of changes (with reason).
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@jfy133
Copy link
Member

jfy133 commented Aug 21, 2024

@harper357 so you don't have to wait for approval each time, if you can go to #github-invitations on the nf-core slack we can add you to the Github organisation and have tests run straight away :)

@SPPearce
Copy link
Contributor

There are tests, they are just written in pytest, the older testing framework.
They could do with moving over, for instance using the nf-core modules create metaphlan/metaphlan --migrate-pytest command.

@SPPearce
Copy link
Contributor

Oh, hold on, @LilyAnderssonLee is working on nf-test in #6139, including bumping the versions, so I'm going to close this one.

@SPPearce SPPearce closed this Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants