Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added nf-test for vsearch/usearchglobal #6239

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

GallVp
Copy link
Member

@GallVp GallVp commented Aug 22, 2024

PR checklist

Closes #XXX

  • Added nf-test for vsearch/usearchglobal with [FEATURE] Port pytest with --migrate-pytest-hard #6226
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@GallVp GallVp requested review from jtangrot and a team as code owners August 22, 2024 04:39
@GallVp GallVp requested review from CarsonJM and removed request for a team August 22, 2024 04:39
@SPPearce SPPearce added this pull request to the merge queue Aug 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Aug 22, 2024
@SPPearce SPPearce added this pull request to the merge queue Aug 22, 2024
Merged via the queue into nf-core:master with commit 38875ea Aug 22, 2024
12 checks passed
@GallVp GallVp deleted the nf-test/vsearch_usearchglobal branch August 22, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants