Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update last/* from version 1542 to 1571 #6349

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

charles-plessy
Copy link
Contributor

@charles-plessy charles-plessy commented Aug 26, 2024

This brings in a fix to maf-convert allowing MAF->AXT conversions when alignment strand is - on the target. This will be useful to a future update of nf-core/pairgenomealign that will add an optional conversion step.

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda

This brings in a fix to `maf-convert` allowing MAF->AXT conversions when
alignment strand is `-` on the target.  This will be useful to a future
update of `nf-core/pairgenomealign` that will add an optional conversion
step.
@SPPearce SPPearce added this pull request to the merge queue Aug 26, 2024
Merged via the queue into nf-core:master with commit 8b9d2a7 Aug 26, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants