Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add motus prep_long #6590
Add motus prep_long #6590
Changes from all commits
00e68a2
1cbee6f
b881c2e
7adbdd4
cf78dcd
d0bc778
11969c9
ddc3cf7
6d6586d
5af72e3
c0c725e
9d66e88
b4971df
226543b
dbbab3c
98ee2fc
1f8d5a5
520b598
aad473d
5e80296
3d9fc0e
01e3640
b435564
5926dce
5223764
260351d
809805a
1dd0666
c5cb81e
59b892a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems strange, why is the input a python script?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to run the module, we need to run the download of the motus db first.This is how we have been doing with the motus profile as well.
https://github.com/nf-core/modules/blob/master/modules/nf-core/motus/profile/tests/main.nf.test#L20
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But the script could just be part of the module?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please explain what you mean? We need the script to run the test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @SPPearce means we could just copy and paste teh code from the mOTUs repository and dump it straight into the module itself.
I think we did this @SPPearce as the script occasioanlly changes to account for changes in where the the database gets downloaded from or something, so it was easier to just download on the fly.
So any copied-code could potentially break.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that is what I meant, to include the script itself with the module for the download module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But if there is a reason behind it then that is fine. It isn't relevant for this module anyway.